1.13.x support

Question

1.13.x support

Nicofisi opened this issue 6 years ago · 18 comments

Nicofisi commented 6 years ago

That's it. 1.13.x support

[01:58:09 INFO]: Nicofisi użył komendy /tomap http://static.cdprojektred.com/thewitcher.com/media/wallpapers/witcher3/full/witcher3_en_wallpaper_the_witcher_3_wild_hunt_ciri_meditating_1920x1080_1446715311.png
[01:58:11 WARN]: [ImageOnMap] Task #22 for ImageOnMap v3.1 generated an exception
java.lang.NoSuchMethodError: org.bukkit.enchantments.EnchantmentWrapper.<init>(I)V
        at fr.moribus.imageonmap.tools.items.GlowEffect.<init>(GlowEffect.java:53) ~[?:?]
        at fr.moribus.imageonmap.tools.items.GlowEffect.getGlow(GlowEffect.java:83) ~[?:?]
        at fr.moribus.imageonmap.tools.items.GlowEffect.addGlow(GlowEffect.java:107) ~[?:?]
        at fr.moribus.imageonmap.tools.items.ItemStackBuilder.item(ItemStackBuilder.java:185) ~[?:?]
        at fr.moribus.imageonmap.ui.SplatterMapManager.makeSplatterMap(SplatterMapManager.java:60) ~[?:?]
        at fr.moribus.imageonmap.ui.MapItemManager.give(MapItemManager.java:78) ~[?:?]
        at fr.moribus.imageonmap.ui.MapItemManager.give(MapItemManager.java:64) ~[?:?]
        at fr.moribus.imageonmap.map.ImageMap.give(ImageMap.java:84) ~[?:?]
        at fr.moribus.imageonmap.commands.maptool.NewCommand$1.finished(NewCommand.java:70) ~[?:?]
        at fr.moribus.imageonmap.commands.maptool.NewCommand$1.finished(NewCommand.java:65) ~[?:?]
        at fr.moribus.imageonmap.components.worker.WorkerCallbackManager$WorkerRunnableInfo.runCallback(WorkerCallbackManager.java:141) ~[?:?]
        at fr.moribus.imageonmap.components.worker.WorkerCallbackManager.run(WorkerCallbackManager.java:113) ~[?:?]
        at org.bukkit.craftbukkit.v1_13_R2.scheduler.CraftTask.run(CraftTask.java:63) ~[patched_1.13.1.jar:git-Paper-193]
        at org.bukkit.craftbukkit.v1_13_R2.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:423) ~[patched_1.13.1.jar:git-Paper-193]
        at net.minecraft.server.v1_13_R2.MinecraftServer.b(MinecraftServer.java:1000) ~[patched_1.13.1.jar:git-Paper-193]
        at net.minecraft.server.v1_13_R2.DedicatedServer.b(DedicatedServer.java:428) ~[patched_1.13.1.jar:git-Paper-193]
        at net.minecraft.server.v1_13_R2.MinecraftServer.a(MinecraftServer.java:936) ~[patched_1.13.1.jar:git-Paper-193]
        at net.minecraft.server.v1_13_R2.MinecraftServer.run(MinecraftServer.java:834) ~[patched_1.13.1.jar:git-Paper-193]
        at java.lang.Thread.run(Thread.java:748) [?:1.8.0_171]

Xeddius · Answer 1 · 2018-11-23T05:41:07.000Z

I too would like to see this updated for 1.13.x It has been an essential part of my server for years and before this I used ImageToMap, etc. 1.13 broke this awesome plugin and I really hope it can be fixed soon.

AmauryCarrade · Answer 2 · 2018-11-23T11:34:31.000Z

You have to understand that I have to make choices and priorities. IoM is not abandoned, but there is a whole chain of dependencies to update before and it is a certain work, plus other unrelated and higher-priority projects.

The reported exception is related to zLib being not compatible with MC 1.13 (the second item of the chain), not IoM.

I hope to be able to update IoM before 2019.

Xeddius · Answer 3 · 2018-11-23T21:26:16.000Z

I appreciate and understand your position. Thank you for the information and all of your hard work!
In the meantime a temporary solution has been to use: https://www.spigotmc.org/resources/custom-images.53036/ until IoM can be updated. It pales in comparison to IoM, but should suffice for those who need a quick, temporary fix.

Tiplish · Answer 4 · 2019-03-08T08:09:05.000Z

Hi,

I would know if the plugin will manage 1.13.X support before summer? I've some features which work with IoM and i have to know if i could wait or choose another way than this plugin to fit my needs :s

Thanks for the answer.

AmauryCarrade · Answer 5 · 2019-03-08T12:14:11.000Z

I have been waiting a long time, for both independent and personal reasons, but I am committed to migrating the plugin by this summer, and I hope before that. I'll work on it as my next personal project, after finishing a current one with a close deadline :) .

Tiplish · Answer 6 · 2019-03-08T12:27:50.000Z

Thanks, i will commit that to my team ;)

Xernium · Answer 7 · 2019-03-09T20:38:27.000Z

@Nicofisi @klugemonkey @tianji1993 @Xeddius @AmauryCarrade
I just completed updating the plugin to 1.13.2 Ill be uploading the source code in a few min :D

Xernium · Answer 8 · 2019-03-09T21:21:53.000Z

#58 @Nicofisi @klugemonkey @tianji1993 @Xeddius @AmauryCarrade has one known gotcha. Other than that works :)

Nicofisi · Answer 9 · 2019-03-10T21:28:04.000Z

Great, thank you! Will try with friends later this week

Tiplish · Answer 10 · 2019-03-11T20:20:06.000Z

Have you the jar somewhere?

Tiplish · Answer 11 · 2019-03-21T16:41:40.000Z

i've try your version @Xernium but... it doesn't work :( Even if i change the POM to specify 1.13.2.

Xernium · Answer 12 · 2019-03-21T17:20:05.000Z

@Tiplish Woah there! If you’re having issues shoot me a DM on Twitter @Xernium or message me on Discord at LDX 0xFF, R17;#3114

Tiplish · Answer 13 · 2019-03-21T17:34:32.000Z

I'm not sure to know how to contact you by discord (impossible to add you as friend :p)

Xernium · Answer 14 · 2019-03-21T17:39:29.000Z

@Tiplish I do have my friends settings set to open. I can try adding you instead if you don't mind sharing your nametag#number

Tiplish · Answer 15 · 2019-03-21T17:44:41.000Z

Tiplish#8686 :)

klugemonkey · Answer 16 · 2018-08-31T18:53:46.000Z

zLib needs updating since EnchantmentWrapper no longer takes id, but rather a string. zLib probably should be fixed for 1.13, since other issues with Banner colors need to be addressed.

tianji1993 · Answer 17 · 2018-10-29T18:48:18.000Z

@klugemonkey
this maybe helpful:
https://www.spigotmc.org/threads/enchantmentwrapper-constructor-arguments-changing-with-versions.329593/

AmauryCarrade · Answer 18 · 2019-11-15T13:52:36.000Z

4.0-pre1 (including 1.13 and 1.14 support) has been released!

Share to