ItemJoin issue: Skull Item bugs
Vatsapon opened this issue · 46 comments
I'm making a SKULL_ITEM with flags: inventory-modify, self-drops. But when I'm joined, The Skull Item can drop and can move around in my inventory. Is this some kind of bugs? [I'm using ItemJoin v.4.0]
Looks to be a configuration issue, can you send your items.yml in a pastebin.com please.
#// <>==<>==<> ItemJoin's Custom Items On Join, by RockinChaos <>==<>==<> //#
#// See the Documentations page for a more in-depth tutorial; https://www.spigotmc.org/wiki/itemjoin/ //#
items-Version: 6
items-Delay: 2
items-Overwrite: false
items-Spamming: false
items:
playgame:
id: COMPASS
slot: 0
name: '&aJoin the field &7(Right Click)'
commands:
right-click:
- 'console: list'
commands-type: interact
commands-cooldown: 5
cooldown-message: '&9[Server] &7Please wait for &c&l%timeleft% &7seconds before using this again!'
itemflags: inventory-modify, world-changed, hide-attributes, self-drops
triggers: join, respawn, region-enter
permission-node: 'itemjoin.menu'
enabled-regions: spawn
enabled-worlds: world
profile:
id: SKULL_ITEM
data-value: 3
skull-owner: '%player%'
slot: 4
name: '&bProfile &7(Right Click)'
commands:
right-click:
- 'console: list'
commands-type: interact
commands-cooldown: 5
cooldown-message: '&9[Server] &7Please wait for &c&l%timeleft% &7seconds before using this again!'
itemflags: inventory-modify, world-changed, hide-attributes, self-drops
triggers: join, respawn, region-enter
permission-node: 'itemjoin.menu'
enabled-regions: spawn
enabled-worlds: world
topstats:
id: PAPER
slot: 7
name: '&6Top Stats &7(Right Click)'
commands:
right-click:
- 'console: list'
commands-type: interact
commands-cooldown: 5
cooldown-message: '&9[Server] &7Please wait for &c&l%timeleft% &7seconds before using this again!'
itemflags: inventory-modify, world-changed, hide-attributes, self-drops
triggers: join, respawn, region-enter
permission-node: 'itemjoin.menu'
enabled-regions: spawn
enabled-worlds: world
shop:
id: EMERALD
slot: 8
name: '&9Shops &7(Right Click)'
commands:
right-click:
- 'console: list'
commands-type: interact
commands-cooldown: 5
cooldown-message: '&9[Server] &7Please wait for &c&l%timeleft% &7seconds before using this again!'
itemflags: inventory-modify, world-changed, hide-attributes, self-drops
triggers: join, respawn, region-enter
permission-node: 'itemjoin.menu'
enabled-regions: spawn
enabled-worlds: world
Just tested it on my server and I'm not having any issues, can you give me a little more information on how you are replicating this issue? Is it upon joining or entering a region?
Once this build is compiled in approx (6 mins) download it and try it, this should fix your skull issues until I release a bug fix tomorrow.
http://jenkins.craftationgaming.com:8080/job/ItemJoin/17/
EDIT: Message back with your results.
No problem. Ill post an official v4.1 update fix late tomorrow. Still have a few other things I need to work out.
The original will work its just not compressed meaning it takes a bit more space but its a minimal difference.
Err... I found the problem again. But it's not about the skull item. It's about dropping item. It keep increasing amount of ItemJoin when I'm trying to drop the item [Happened to all ItemJoin]
Er.. Can I ask you a question?. What version of WorldGuard that can use with ItemJoin?. Because I'm using older version [WorldGuard v.5.9]
You can use any worldguard version. There a little bug with creative mode atm that I am trying to work around. This is an issue with Mojang sadly.
When I'm cleared my inventory in other region and rejoin, ItemJoin has been given. How to fix this?
How to make the ItemJoin give in only specific region and when walking out of that region. ItemJoin will gone?. Because I'm trying to do that. But it doesn't work
Oh. And I found another bug. When you make Prevent-Pickups: false in config.yml. Every normal item that has been used in ItemJoin can't picked up
Sorry, If you make Prevent-Pickups set to true and in item.yml have the COMPASS item as the ItemJoin. When I'm join the game and drop normal compass, I can't picked it up
You have to set WorldGuard to true and set enabled-regions: (region name). Then set region-enter to your triggers.
Little confused what you mean by prevent-pickups. If its set to false you can pickup items?
That is intended thats what the feature is suppose to do. It prevents the picking up of items. Its enabled by default for ItemJoin items, some people just wanted the option for all items so I added prevent-pickups.
So once you walk into that region under enabled-regions you dont get the itemjoin items?
I've already set WorldGuard in config.yml to true, add enabled-regions, add trigger: region-enter. But it still no use...
Er.. What should i say.. Er... I have set trigger: join, respawn, region-enter | enabled-regions: spawn. When I'm in other region [I'll say as "A" region] instead of "spawn" region. I'm trying to clear my inventory and rejoin the server. It still give me the ItemJoin in "A" region. How do i fixed this?
can you send your current items.yml in pastebin.com
It seems to be a configuration issue, I checked over the code and tested it and its working properly for me.
The enabled-regions only apply to walking in and out of the regions, or joining in the region. Once in the region you will be given the item. Once leaving you will lose the item, however if you use the join trigger and or world-changed and or respawn trigger is used it will be given anywhere.
Ohhhh!! Your re-joinning the server in the "A" region. You have the join trigger on which means items will be given on join. if you dont want to receive items on join then remove the join trigger.
OK. It doesn't give any ItemJoin when I'm joined now. But I still don't get any item when entering "spawn" region or respawn or rejoin in "spawn" region.
But If that can't fix. I will use ItemJoin in per world instead. So all the problem will be gone.
I want it like.... When I'm in "spawn" region or die and respawn or rejoin in "spawn" region. It will give the ItemJoin. but when I leaving the region and playing in "A" region or rejoin in "A" region. It will took all ItemJoin out of my inventory
Send your items.yml in a pastebin.com Ill configure it for you, its just a config issue.
All you have to do is set enabled-regions to spawn and triggers to region-enter. Then when you enter spawn, respawn into spawn, or join the server to spawn it will be given to you since you are in the regions spawn.
I might have just fixed the issue you are having, try http://jenkins.craftationgaming.com:8080/job/ItemJoin/18/
I join and get the items only when in the region as well as respawning.
It works just using the trigger region-enter.
Let me know if this worked for you. Sorry for the hassle its really late for me and my mind is going dumb lol.
EDIT: Issue was fixed in the v4.1 update. https://www.spigotmc.org/resources/itemjoin.12661/download?version=169234
I will try that and will tell you a result soon. (Sorry for let you waiting for a long day, I'm very busy since that day)
Its all good I know the feeling. I just started summer quarter of college so I been busy as well.
I've tried to add a trigger: region-enter, respawn ¦ enable-region: spawn in item.yml. When I'm leaving spawn region, It still don't remove ItemJoin. Am I doing something wrong? (I will give you a item.yml file later, I'm busy today)
Make sure its triggers:
Not trigger:
Also its enabled-regions not enable-region. I presume it was just a typo and its not like that in ur items.yml.
Defiantly send your items.yml when you can I feel like there is a typo somewhere.