In the tab completer should be included only the main command
leonardo-dgs opened this issue · 14 comments
1.) Vesion: 5.0.4-SNAPSHOT.
2.) Spigot 1.14.4.
3.) In the tab completer, when you type /itemjoin are shown all the subcommands, it's very annoying. It should only include the main command, and once you have typed the space after /itemjoin, you should see the sub commands in the tab completer.
I'll see what I can do about the tab completion, its an issue on the spigot side not properly listing them so ill likely have to rewrite their tab-completion class.
EDIT: I can confirm this will require a custom tab completer class, which is going to take some time to program. Not sure if this will make it to the v5.0.4 release or not. ~ Stay tuned.
This has been added in the latest snapshot, please let me know if there are any issues.
http://ci.craftationgaming.com/job/ItemJoin/
@RockinChaos There is still the issue.
Doesn't seem to be reflected on my end, can you send me a screenshot of the /itemjoin
output.
@RockinChaos What? That's the problem, subcommands should only compare when you type a space after /itemjoin command
@RockinChaos There should be a permission even for showing /itemjoin help and /itemjoin command output, and in that case the /itemjoin tab completer should be completely disabled.
I was asking for you to physically type /itemjoin and hit enter so I could see the version you are running (since its the best way to see if there was an accidental duplicate).
The beginning when typing /itemjoin
is not a part of the tab completion until you hit space after /itemjoin
the part you are having issues with is the spigot parser. I have simply removed the secondary commands from the plugin.yml so let me know if this change reflects what you are intending; http://ci.craftationgaming.com/job/ItemJoin/300/
Okay, this should be resolved now in the latest b301; http://ci.craftationgaming.com/job/ItemJoin/301/
Not quite sure why I couldn't get it to reflect the same way on my end but regardless it seems to be fixed.
Yes, now it's fixed, thank you, but you can tab-complete and show the command help even if you don't have permission.
Resolved the permission issues; http://ci.craftationgaming.com/job/ItemJoin/302/
I have added each individual permission for each tab-complete & sub commands
That would be itemjoin.use
which is enabled for all players by default.
-- /itemjoin permissions
is also enabled by default itemjoin.permissions
You would have to set the node to false in a permissions plugin for the player groups that you don't want to have access to it.
For example, in LuckPerms the default player group can have the permission itemjoin.use: false
and itemjoin.permissions: false
so the permissions are not given to those players.