ItemJoin

ItemJoin

157k Downloads

Autocrafting book recipes moving crafting slot items

emerickchasse opened this issue · 4 comments

commented

Server Version

PaperSpigot 1.20.1

Resource Version

ItemJoin v6.1.0

Dump Information

https://ci.craftationgaming.com/dump/?id=meqosigeja

Describe The Bug

Autocrafting book, recipes move crafting slot items that are not interatable causing them to shift on hot bar and cant be moved.

Expected Behavior

Not moving the items when using autocraft book (even recipe with items I don't have)

Steps To Reproduce

  1. Set items to crafting slots
  2. Open Autocrafting Recipe book
  3. Choose an item you cant craft
  4. Items will shift into hotbar, even if they are not moveable
    Before:
    image
    After:
    image

Additional Info

No response

Checklist

  • I am running latest version of this resource.
  • I have read the wiki to make sure it's not an issue with configuration.
  • I ticked all of these boxes without actually reading them.
  • I have checked that my bug report is unique and a previous report does not exist.
commented

Thanks for providing your dump url, you said 1.20.1 but it looks like your running 1.21.1. In 1.20.5 they changed how the recipe packets work so I implemented a fix back then, but apparently... in 1.21+ they changed it back for whatever reason so this has been broken for some time.

Thanks for reporting the issue! I made some changes and it appears to be functional again in the latest snapshot.
Link; https://ci.craftationgaming.com/downloads
Remember to remove your old ItemJoin.jar file

Let me know!~

commented

Remember to remove your old ItemJoin.jar file
Yeah you right I am on Paper 1.21.1 sorry. I upgraded to dev build 1043 (v6.1.1-SNAPSHOT-b1043) and still experimenting the same issue.
image

Here is my new dump: https://ci.craftationgaming.com/dump/?id=ibuwerisok

I tested as OP and non-OP and it's the same thing.

commented

Remember to remove your old ItemJoin.jar file
Yeah you right I am on Paper 1.21.1 sorry. I upgraded to dev build 1043 (v6.1.1-SNAPSHOT-b1043) and still experimenting the same issue.
image

Here is my new dump: https://ci.craftationgaming.com/dump/?id=ibuwerisok

I tested as OP and non-OP and it's the same thing.

Well, that's rather disappointing. Seems paper decided to change their server-side packet names so it broke the naming convention across other server forks. I was primarily testing with spigot so I didn't encounter this issue.

I made some changes specific to paper that seem to have resolved the issue from my testing. Sorry about that.
Link; https://ci.craftationgaming.com/downloads
Remember to remove your old ItemJoin.jar file

Let me know!~

EDIT: Official release is now available.
Link; https://www.spigotmc.org/resources/itemjoin.12661/download?version=567092

commented

Yes, it's fixed !! Thank you