Server Version

1.21.1

Resource Version

6.1.1 b1048

Dump Information

https://ci.craftationgaming.com/dump/?id=ejawohociz

Describe The Bug

Expected Behavior

unsure

Steps To Reproduce

unsure

Additional Info

No response

Checklist

• I am running latest version of this resource.
• I have read the wiki to make sure it's not an issue with configuration.
• I ticked all of these boxes without actually reading them.
• I have checked that my bug report is unique and a previous report does not exist.

Looks like the ChestSort API has changed, I'll look into this and see if it's an ItemJoin side issue, from a quick glance it doesn't look ItemJoin related as its throwing an error where there should be viewers but it's possible they changed the player to be fetched elsewhere.

Will let you know soon.

Thank you

So upon further investigation, this appears to be a bug with eShulkerBox's implementation of ChestSort.
I took a look into ChestSort and it shouldn't be possible for the player to be null, especially an inventory without viewers but this can be circumvented with their API. When looking at your error it seems to originate from eShulkerBox which is using the ChestSortAPI so this makes sense.

Well, regardless I would rather it not throw errors with ItemJoin since it's not really an ItemJoin issue so I made some fixes to prevent this error. However, keep in mind that any ChestSort action that has a null player will be allowed through since ItemJoin can't check if it's moving a custom item or not is restricted. However, given the nature of eShulkerBox, this won't matter since it won't be moving ItemJoin items that it shouldn't. In a perfect world though, eShulkerBox should be setting the viewing player for the inventory before passing it to ChestSort to prevent this issue. In reality, ChestSort should force API usage to require a player/viewer to be present.

Link; https://ci.craftationgaming.com/downloads
Remember to remove your old ItemJoin.jar file

EDIT:
The official release is now available.
Link: https://www.spigotmc.org/resources/itemjoin.12661/download?version=577922

okay ill relay it to the dev, thank you so much!

Hey Idk if it's because the update to fix that issue, but im seeing itemjoin is pretty high on my spark profiler, this one isnt the best example but it was the highest plugin on my spark profile yesterday. Im wondering if its something that was with this issue?
https://spark.lucko.me/qvqaQdRTdy

oh derp... so after checking you're running an older snapshot that contained tps issues.
Update to the new release v6.1.2 and test again xD

very likely the case, check back in a day or so and if it seems resolved you can let me know and close this issue :) <3

Hmmm so it looks pretty normal to me but I do see a spot where I can make some improvements, give me a bit to work on this. I'll provide you a snapshot you can test shortly.

Okay, today it seems to be REALLY good, idk for teh last two days it was top of the list.

https://spark.lucko.me/1fQ5zWLkTZ
hows that looking, normal?