Marriage Master

Marriage Master

4M Downloads

Marry gift

slvlr opened this issue ยท 5 comments

commented

Help request

Problem
Players are using /marry gift to give people items in the mob arena.

What I have tried
One solution would be to RequireConfirmation: true , however in doing this I have found a potential bug.
Once typing /marry gift, the item leaves your inventory. If your partner then declines the gift, and now you have a full inventory, the item appears to not get given to anyone and is removed from the game.

Idea
One potential fix for this would be to prevent receiving gifts if a player was in a certain worldguard region?

Please advise if you have any other ideas, and also how to fix the issue with the item vanishing from the game?

commented

With this build items that will not fit into the senders inventory will now drop to the ground and the sender will be informed about it.
Also if you take away the marry.accept permission while your players are in the mob arena the gift request should be instantly denied.

I have added wg support to the todo list. But I have no idea when I will have the time to add it.

On my server I used a extra world for all fighting related features, this allowed me to block everything that I don't want my players to use by blacklisting the world and setting permissions based on their world.

commented

2021-09-14_22 49 16

I marry gift my partner,
My partner neither accepted or declined it, but left the game.
It said my gift was returned to me however it wasn't?

Edit - This only happened once I am not sure what I did differently, but I seem to get the item now each time my partner leaves.

commented

This didn't even fix my issue because you can /marry gift someone, then join the mob arena, then have your partner deny it to get it returned to your inventory.
Please could you add a blacklist of commands you can use while a marry gift is pending acceptance, so that I can block the /ma command while you are sending a gift?

commented

The deny - inventory full thing works though

commented

BUG:
If you /marry gift one item, and then /marry gift another item before the previous gift was accepted. If you accept the second gift, and then accept the first gift after, It says "There is no open request to accept." and the first gifted item is lost and not returned to either player.