MCTowns

MCTowns

52.4k Downloads

Adding players / Joining towns where player already exists - Proper Message

apengstrom opened this issue ยท 6 comments

commented

Hello, this should be an easy one. I've noticed I can invite players to towns over and over again. Also, when the player joins, I can invite them again and they can also join again.

Can we set up some checking and messaging so that:

  1. Players that exist in a town can't /mct join [townname] again.
  2. Players that have applied already can't /mct join [townname] again.
  3. Mayors / Assistants can't /town add player [playername] to a player that exists in the town already.
  4. Mayors / Assistants can't /town add player [playername] to a player that already has been invited.

There should be a proper message returned for each scenario. There's a lot of confusion on the server right now as to whether or not people are actually in towns.

Thanks!

commented

Is this fixed in one of the more recent versions?

commented

Ah no, still need to make these changes.

commented

Fixed in 3bc519c

commented

Implemented in commit 86cbc45

commented

Can we add one for removing a player as well? I can remove a player over and over again, even if the player does not exist in the town. Thanks!

EDIT: I tested the others and they seem to work fine. Thanks!

commented

Ah, I didn't think about removing. I'll do that too.