Title says it all. I'm not sure if you had this disabled or not, given all the changes that have been happening, but as per screenshot below, I had someone who had requested to join my town but I never was able to see their name in the list.

Another bug with this. A player added me to his town, I typed /mct join [townname] to accept. It said I submitted a request to join the town. I had him add me again, and then he said it has already sent an invite. To paint a better picture, I had my town set active. He had his town set active. He is a regular user. I am an admin. Not sure if any of that matters, but just for background info...

Thanks

Was there an update for this in one of the recent builds? I just realized it was marked as Verifying Fixed still.

This isn't fixed, I still need to look into what's wrong with it. The whole JoinManager class needs to be overhauled and properly unit tested, it hasn't been touched in a while and I wasn't too satisfied with it when I wrote it.

Hm, I fixed the bug where requests never got removed, but I can't reproduce your issue in the picture.

Reproduction steps:

Town is named Anvil, Player M is mayor, player P is random player

• M runs /town add player P
• P runs /mct join Anvil

P is now a member of Anvil.

I think I've found the issue.

Reproduction steps:

Player is named "Notch"

• M: /town add player notch
• P: /town join Anvil

The town will now have a request from "Notch" to join the town, but the town will have an invitation for "notch".

Technically, this is a valid situation. MC usernames are case-sensitive, though the client's login appears to be case-insensitive. I can't find a definitive answer as to whether the accounts Notch and notch can both exist, and I don't have ~$40 to find out ;).

So, for now, if Notch is online and you invite notch, it will warn you about case sensitivity.

Hm, that's concerning. Let me get home and review the code.

By the way, sorry for randomly disconnecting the other night. My internet went out for about 10 minutes.

No problem. I had figured something happened, weather's been pretty crazy across the country past few days. We were having electric issues this morning at work, too.

Fixed in commit 69f6d01

I found a small bug with this fix.

1. Player requested to join town with /mct join [townname]
2. I typed /town list requests, and saw their name.
3. I typed /town add player [playername] and they became a member of the town.
4. I typed /town list requests, and their name was still there. Adding them again stated they were a member of the town, which they were. The request just isn't getting deleted. Inviting works, though. So it's just when they request and I add them.

Hm, weird that invites clear themselves but requests don't. I'll look into that.