Minepacks

Minepacks

2M Downloads

Players with no permision for backpack.size have access to a backpack

Klawdek opened this issue ยท 1 comments

commented

Information

Environment information
Plugin + server version info:

24.05 19:53:57 [Server] INFO ##### Start Minepacks version info #####
24.05 19:53:57 [Server] INFO Minepacks: 2.4.5.1-Release
24.05 19:53:57 [Server] INFO Server: git-Paper-329 (MC: 1.18.2)
24.05 19:53:57 [Server] INFO Java: 17.0.1
24.05 19:53:57 [Server] INFO #####  End Minepacks version info  #####
<!-- Replace this with the output of "/backpack version". You can run the command in your console or as op ingame. -->

Online mode: NO
BungeeCord: NO

Server/crash log


<!-- Replace this with your crash log / link to your log file -->

Plugin config (optional)


<!-- Replace this with details about your config -->

Details

Description
Players that do not have backpack.size permission are given a backpack anyways. It seems to give them a backpack upon having the perm backpack.use without the backpack.size permission being given.

Steps to reproduce
On my server for some reason I put the backpack.use perm for the default group. Not sure why other than basic perms to use a plugin are often given to the default group and perms regarding specific use are given in the appropriate rank group.

Players with only perm to use backpack are allowed to access a 1 row backpack despite not have the perm backpack.size.1
Expected behavior

I would not have expected players to get backpack with only the one perm. I would have expected such behavior to be documented.
Other information (e.g. detailed explanation, related issues, suggestions how to fix, links for us to have context, screenshots, etc.)

commented

Yes, if a player has the backpack.use permission, the player will always get a backpack (with at least a size of 1).
This is to make the check if the player can use the backpack faster.
That behavior should be documented on dev.bukkit and spigot. But was indeed missing in the wiki (I have added it there)