"Loading Paper plugin in the legacy plugin loading logic"
EmanYm opened this issue ยท 5 comments
Information
Environment information
Plugin + server version info:
Host: Apex
Server Jar: Purpur v1.19.3-build1933
MinePacks-Normal v2.4.18
PCGF v1.0.39b721
> 01.05 16:09:43 [Server] INFO ##### Start Minepacks version info #####
> 01.05 16:09:43 [Server] INFO Minepacks: 2.4.18
> 01.05 16:09:43 [Server] INFO Server: git-Purpur-1924 (MC: 1.19.3)
> 01.05 16:09:43 [Server] INFO Java: 17.0.7
> 01.05 16:09:43 [Server] INFO ##### End Minepacks version info #####
Online mode: No
BungeeCord: Yes (Velocity)
Server/crash log
Edited log to keep just the relevant details. A complete start up log can be provided if required.
https://gist.github.com/EmanYm/b0a9816e513ae037fde2383a34781609
Plugin config (optional)
I feel that configs are irrelevant to this situation, but I am including them for completion of the ticket
https://gist.github.com/EmanYm/37563669a8251d1b025790518e70ae69
Details
Description
If you're not using the Standalone version of MinePacks it will think it's loading legacy code
Steps to reproduce
I have switched out the version of the plugin and the library combination I listed above and tried the following
Using the MinePacks-Standalone I no longer have the above messages in the console.
Using MinePacks-Normal and PCGF I get the message only for PCGF
Using MinePacks-Release and PCGF I get the console messages I reported
Expected behavior
It is expected that the plugin will load regardless of plugin <-> library combination
Other information (e.g. detailed explanation, related issues, suggestions how to fix, links for us to have context, screenshots, etc.)
I plan on also using MarriageMaster. I have not tested it yet, but I suspect it might have the same issue.
I can not reproduce this with latest purpur. Can you please try it with an updated version of purpur?
Purpur1.19.4 + MinePacks2.4.18-Release + PCGF1.0.39
https://gist.github.com/EmanYm/25001b7aa1970aac26cd6c43db06b42d
Both get the notice
Purpur1.19.4 + MinePacks2.4.18-Normal + PCGF1.0.39
https://gist.github.com/EmanYm/57f8b3ba2320ab8e9b667a3cf1a349b0
Just CGF
Purpur1.19.4 + Minepacks2.4.18-Standalone
https://gist.github.com/EmanYm/b53f435b0b387110e0ac2d76bbc77b96
None
I don't know where Spark keeps coming from, the only plugins are the two I'm testing, and I've even deleted the Spark plugin from the cache folder.
Apparently Spark is bundled with Purpur...there is no way to get away from that
You are running with -Dpaper.useLegacyPluginLoading=true
? In that case just ignore the message (unless you encounter any issues actually using the plugin). My plugins are already using paper plugin loading logic for the release build config.
That looks like a JVM argument. I don't have access to change those, unfortunately.
I have mostly ignored it, since it doesn't appear to effect the operations of the server or plugins. It's odd that it only happens with PCGF.
I'll mark this as closed so it's not clogging up the ticket queue. Thank you for your time, Georg!