Using 4.4.1-SNAPSHOT, not every fish that I catch gives money. (This might also apply on older versions, but now the messages are working I notice about this)

First 2 fishes didn't give money, then 3 gave money and then again a fish didn't give money. Seems to be a bit buggy. 80% of the times it works fine though.

That's alright! It works most of the times. This is a minor bug I think.

Sometimes the fish (as an item to be piucked up) is in the water instead of the inventory. I this case you will still get the reward. Try fishing on low water near by you, then you will see.

I don't have a solution for this, because you caught a fish, you just didnt got it in your inventory. I cant solve that, because the "PlayerFishEvent" does not give me the information.

It is either Minecraft or the Bukkit API which is buggy. I cant do anything than making an report to the Spigot team.

Hmm, the item was actually in my inventory. However usually it goes into a hopper, but not this time.

But it's suppose to give the money even when the fish is not in my inventory? Then why doesn't it give cash everytime?

The fish I catched yesterday didn't give money, but it was in my inventory.

The PlayerFishEvent in the Bukkit API seems very buggy and the documentation does not reflect what actually happens. It look like the PlayerFishEvent is call with wrong states. I can fix this I think it's a Minecraft / Bukkit API bug. I need time to makeep a bug report.

I have reported the issue
https://hub.spigotmc.org/jira/browse/SPIGOT-3059

Lets hope they can do something.

@Rocologo This bug is getting worser or something..

I will report this problem to the spigot team

Thanks, appreciated

He rejected the bug report. And asked me to provide evidence and a way to reproduce this bug.

So I am on my own again. So I have worked on it again and studied the @eventhandler and its settings.

I think it works alot better now (still not 100% perfect), and it works with mcmmo too.

Please test this one
https://dl.dropboxusercontent.com/u/36067670/MobHunting/MobHunting-4.4.4-SNAPSHOT-Bnull.jar

My Jenkins server is down until tonight, so you have to fetch it from dropbox.

Will test! McMMO? You mean items?

yes, McMMO sometimes change the caught fish to another item. I have seen TNT, RECORD, SPADE, if McMMO or anyother plugin changes the fish to something else, the player will not get a reward.

I have made extensive debugging information. So we can see what happens if anything goes wrong.

The only strange thing I have seen for now is that I sometimes catches more than one fish in this case you also get the same number of rewards. Both money and heads. I dont know if this is McMMO too.

Been fishing for the past 20 minutes. I received cash for every fish, and didn't receive cash for items. Nice catch! :)

If issues occur on the main server, I will let you know, but on my test server it works fine now.

On my server too :-) This one has been hard to solve :-)

I close this now.

Indeed! Glad it's fixed :)

Seems he replied :)

I just tested with staff, and it happens way to often that you don't receive money for fishing. It's like 60% yes, 40% no. Hope MD_5 can do something.