MobHunting

MobHunting

114k Downloads

Bug: money drop missing configured head

SlimeDog opened this issue ยท 30 comments

commented

It would be awesome to be able to gift a BagOfGold to a player! Something like

/mh give money amount

command, which would give me the ITEM or SKULL reward, which I could then drop to the player. Or maybe put it in a chest. So someone with appropriate permission (for example)

mobhunting.giverewards

would be able to handle a reward without redemption, but when the player picked it up or took it from the chest, it would be redeemed. Just thinking out loud...

commented

Thank you for making a ticket on this :-)

This will be easy to make. I'm currently investigation if I can save the value of the "bag of gold" on the item, so it can have a value. If I cant make this I will make "simple" solution for you.

You just have to be patient because I dont have much development time these days and I need time to fight bugs too. :-)

commented

You can do /mh money drop in V4.5.0

commented

Spigot 1.11.2, MH 4.5.0.

/mh money drop 1

did not drop anything on the ground. Also, the text includes a decimal

You dropped 1.0

commented

MH 4.5.1.

I'm seeing a drop, but it's a Steve head, not a Bag of Gold.

commented

I think the commands should be:

Admin command (permission mobhunting.money.give)
/mh money give playername amount

  • to give the player a bag of gold in his inventory. Question is if the money should be added to an existing bag or as a new bag. The money will be take from the "server" and not the player who executes the command.

/mh money take playername amount

  • to take some of the players money from his inventory. If amount is bigger or equal to the money in his inventory, the bag will be removed. The money will be given to the server and not the player who executes the command.

Admin command: (permission mobhunting.money.balance)
/mh money player

  • to show the value of the players total back of gold in the player inventory.

Admin command:
/mh money drop amount

  • to drop some money in front of you. Question is if the money should be take from the player who executes the command or the server?

Sign to convert the "bag of gold" to the players acount. The sign must be placed on a chest. Left click to sell, Right click to buy
Line1: [MH SHOP]
Line2: |
Line3: SELL|BUY
Line4: ALL|

Line 1: Is a TAG so the plugin can recognize the "Shop sign"
Line 2: If the line is owner the owner will get the money/bag of gold, but not more that the player has on his account/bag of gold. I havnt thought this through yet. Im not sure if it is a god idea or if it only can be an Admin sign.
Line 3: Tells if the sign can be used for trading both way. Left click to SELL, Right click to Buy
Line 4: could be ALL or a number, if ALL all "bag of gold" or "money" will be converted, and account will be updated.

Player commands (permission: mobhunt.money.sell)
/mh money sell amount

  • to convert bags of gold in the players inventory to money on the players account. Can be used instead of the sign.

Player commands (permission: mobhunt.money.buyl)
/mh money buy amount

  • to convert money in the players account to bags of gold in his inventory. Can be used instead of the sign.

Any more ideas?

This will take a lot of time to make all these features....

commented

I wasn't thinking of creating a whole new economy. I was thinking only that OP would be able to perform this magic. I was expecting that a bag of gold (or ingot, or whatever) would be converted to cash whenever a player touched it. The idea was to be able to gift a player: drop it at their feet or put it in a chest. In either case, when they pick it up, it is converted. That seems a lot simpler to me, and removes the need for a lot of specialized code to let players store bags.

commented

Yea, well you talked about a sign too :-) and a sign will demand the above features.

So I think you would like to have this feature first.

Admin command:
/mh money drop amount

  • to drop some money in front of you. Question is if the money should be take from the player who executes the command or the server?
commented

That would do it. And it's the only command I need. Others may what more. (I reserve the right to want more in future.)

Funds should come from the server. The same "account" that funds mob kills. Basically, the issue is that I reward players for many things besides mob kills. Using the same mechanics simplifies life.

commented

I like

/mh money drop amount

as an adjunct to my existing economy. It's a pretty, visual way of giving rewards, not significantly different from killing a mob.

I think it is a mistake to invent another full-blown economy.

commented

MH 4.5.2

Still seeing a Steve head when I drop a bag.

UPDATE: Also seeing a Steve head when I kill a mob.

commented

Please drop the skull item close by, and on the same Y level.

The item can drop a significant distance away from me. If I am close to a stairwell, it may drop down to the next floor (floors are Y=4 apart) or into the stairs. Once it "dropped" onto the floor above. Once I could not find it at all.

commented

You have to look at the block where you want the money dropped.

commented

Oh. Well, then...

If it were a bag of gold instead of a Steve head, everything would be peachy. This occurs both on drop and on kill mob. I reconfigured the skull definition, just to be sure. I also went back to the default bag-of-gold definition. Still no joy. There are no in-game or log errors. What might I be doing wrong?

commented

Please try newest build, I have changed the way i calculate where to drop the bag. Distance will now be max 20 blocks from you, in the direction you look.

You can also use /mh money drop and the the bag will spawn 3 block ahead in the direction the player look.

http://jenkins.lindegaard.one:8180/job/MobHunting/

I have made the other commands too: give,take,buy,sell but give+take does not remove the items from the inventory. (BUG). I need to sleep now, and do not have much time tomorrow.

commented

Spigot 1.11.2, MH 4.5.3-b292.

Drop seems fine. Pretty funny to launch the item and watch it fall from the sky. :)

I did not test the other commands.

The head is still Steve, not skinned to Bag of Gold. Will either debug node help with this?

debug_sql: false
kill-debug: false

Drop reports the value with unnecessary decimal point and digit, for integer value.

reward_rounding: 1.0

commented

No. I dont understand why some of you get a Steve head. I do still get the bag of gold. This is something i really cant do anything about. Its all about how Minecraft (and Mojang) chooses to update the heads. The thing is that Im using a method created by InventiveTalent, who also made http://mineskin.org

If the method does not work I cant fix this, then you have to go back to the gold ingot :-(

commented

in fact I use the same method for making all heads, inclusive the mobs heads, when you get one of these in your inventory, after a kill.

commented

If you can back out the new economy code, except for money-drop, I could quickly test to proposition.

commented

I removed the entire plugins/MobHunting/ directory and restarted the server, to regenerate the default configuration. The same problem with heads occurred.

I did not experience this issue until the money-drop-command update. As a test, I reverted to MH 4.4.8, with no other changes to my system. MH 4.4.8 does not contain the money-drop-command, of course. But when I kill a mob, I see the correct Bag of Gold drop. So I posit that the new drops/currency code changed something about heads. It's most likely an interaction with some other plugin, but it is presented by MH.

commented

I don't know how to solve the "Bag of gold" texture problem, I have tried to change the UUID, to see if this helps.

Please test Build 293 or newest, tell me if this works...
http://jenkins.lindegaard.one:8180/job/MobHunting/

commented

I didnt see this until now : I did not experience this issue until the money-drop-command update. As a test, I reverted to MH 4.4.8, with no other changes to my system. MH 4.4.8 does not contain the money-drop-command, of course. But when I kill a mob, I see the correct Bag of Gold drop. So I posit that the new drops/currency code changed something about heads. It's most likely an interaction with some other plugin, but it is presented by MH. this tells me that Build 293 will fix the "Bag of Gold"

commented

293 does not fix the bag-of-gold issue. Both drops and kills still display the Steve head.

I could not figure how to get to Survival on your server. Portals go nowhere.

commented

Try picking up a head and place it as a block, and then break it again, a couple of times, to see if this fixes the problem like it did on my server????

commented

Did you want me to place and break the bag-of-gold head? or some other head? What command do I use to get a bag-of-gold head? I tried the following:

/mh money give playername 5

That dumped the money into be economy balance. I'm not fast enough to see if there was a flying head temporarily.

/mh head playerName playerName

That gave me my own head. I placed it on a wall, then broke it. Several times. No change in the MH drop result.

Grab a copy of the bag-of-gold I use, from a commandblock

Placed it on a floor, then broke it. Several times. No change in the MH drop result.

What specifically did you do, that worked? What else should I try?

commented

If you set "drop-money-use-item-as-currency: true" you can pick up and carry, break and place, buy and sell the bag of gold. This was what i did....

commented

Test protocol (on my test server):

Part 1

  • Start server
  • Drop money, which displays Steve head
  • Stop server

Part 2

  • Configure "drop-money-use-item-as-currency: true"
  • Start server
  • Drop money, which displays correct Bag-of-Gold head
  • Stop server

Part 3

  • Configure "drop-money-use-item-as-currency: false"
  • Start server
  • Drop money, which displays Steve head
  • Stop server

So something is missing in the logic applied when "drop-money-use-item-as-currency: false". Possibly the head evaluation logic is in a currency-mode=true block?

commented

I worked alot on v4.5.4 to fix this issue. Please help me test v4.5.4

commented

Confirm that with

drop-money-use-item-as-currency: false

MH 4.5.4 drops perform as expected:

  • skin is my bag-of-gold: mineskin.org/6875
  • funds are added to my economy balance on pick-up
  • no bag in inventory

All correct.

commented

Yes!!!!

I saw that skin yesterday, and I liked it, I actually thought about using your, as default, because it does not have the $...

commented

Agreed. I like it much better. That's why I used it.