Multiverse-Inventories

878k Downloads

New Groups not taking effect until restart

nicegamer7 opened this issue ยท 7 comments

commented

Information

Details

I was able to reproduce my issue on a freshly set up and up-to-date server with the latest versions of Multiverse plugins with no other plugins and with no kinds of other server or client mods.

Description
Creating a new group in Multiverse-Inventories does not take effect until a server restart. Prior to 4.2.2, they would not take effect even after a server restart if the player had visited one of the worlds in the group.

Steps to reproduce

  1. Set up a fresh server with MV Core and Inventories.
  2. /mvc TESTER normal and /mvc TESTER_nether nether.
  3. Group the two new worlds and share everything using /mvinv group.
  4. Visit TESTER and add something to your inventory.
  5. Visit TESTER_nether

Expected Behavior
Your inventory should be shared.

Actual Behavior
A blank inventory is observed.

Workaround as of Multiverse-Inventories 4.2.2 (not working on 4.2.1 if the player has visited either world already)
Teleport back to TESTER, then restart the server.

commented

Maybe I'm doing it wrong but I can't really reproduce it. Can you provide logs with debug mode enabled on world changes during this issue?

commented

Sure, I'll get some logs in a couple hours.

commented

Actually, testing again, I can reproduce the issue. I will provide logs if I can as well.

And also time for hours of debugging.....

commented

Full log: https://pastebin.com/FTJcntBR
version paste: https://paste.gg/01aac7ebd9314abc9cd3f77428abc42a

Here is the logs when teleporting to TESTER from default world:

[13:23:36 INFO]: Benji_0224 issued server command: /mvtp tester
[13:23:36 INFO]: [Multiverse-Core-Debug] Checking to see if player [Benji_0224] has permission [multiverse.teleport.*]... YES
[13:23:36 INFO]: [Multiverse-Core-Debug] Checking to see if player [Benji_0224] has permission [multiverse.teleport.self.w]... YES
[13:23:36 INFO]: [Multiverse-Core-Debug] Adding mapping 'Benji_0224' => 'Benji_0224' to teleport queue
[13:23:36 INFO]: [Multiverse-Core-Debug] The first location you gave me was safe.
[13:23:36 INFO]: [Multiverse-Core-Debug] Got teleport event for player 'Benji_0224' with cause 'PLUGIN'
[13:23:36 INFO]: [Multiverse-Core-Debug] Inferred sender 'CraftPlayer{name=Benji_0224}' from name 'Benji_0224', fetched from name 'Benji_0224'
[13:23:36 INFO]: [Multiverse-Core-Debug] Player 'Benji_0224' was allowed to go to 'TESTER' because enforceaccess is off.[13:23:36 INFO]: [Multiverse-Core-Debug] MV-Core is allowing Player 'Benji_0224' to go to 'TESTER'.
[13:23:36 INFO]: [Multiverse-Inventories-Debug] === Benji_0224 traveling from world: world to world: TESTER ===
[13:23:36 INFO]: [Multiverse-Inventories-Debug] got data folder: plugins\Multiverse-Inventories\worlds\world from type: WORLD
[13:23:36 INFO]: [Multiverse-Inventories-Debug] Created player profile from map for 'Benji_0224'.
[13:23:36 INFO]: [Multiverse-Inventories-Debug] [ProfileType:SURVIVAL - WORLD - world - Benji_0224] not cached, loading from disk...
[13:23:36 INFO]: [Multiverse-Inventories-Debug] got data folder: plugins\Multiverse-Inventories\groups\default from type: GROUP
[13:23:36 INFO]: [Multiverse-Inventories-Debug] Created player profile from map for 'Benji_0224'.
[13:23:36 INFO]: [Multiverse-Inventories-Debug] [ProfileType:SURVIVAL - GROUP - default - Benji_0224] not cached, loading from disk...
[13:23:36 INFO]: [Multiverse-Inventories-Debug] No groups for toWorld.
[13:23:36 INFO]: [Multiverse-Inventories-Debug] ender_chest, inventory_contents, armor_contents, off_hand, hit_points, remaining_air, maximum_air, fall_distance, fire_ticks, xp, lvl, total_xp, food_level, exhaustion, saturation, bed_spawn, last_location, economy, potion_effects are left unhandled, defaulting to toWorld
[13:23:36 INFO]: [Multiverse-Inventories-Debug] got data folder: plugins\Multiverse-Inventories\worlds\TESTER from type: WORLD
[13:23:36 INFO]: [Multiverse-Inventories-Debug] Created player profile from map for 'Benji_0224'.
[13:23:36 INFO]: [Multiverse-Inventories-Debug] [ProfileType:SURVIVAL - WORLD - TESTER - Benji_0224] not cached, loading from disk...
[13:23:36 INFO]: [Multiverse-Inventories-Debug] Change affected by 2 fromProfiles and 1 toProfiles
[13:23:36 INFO]: [Multiverse-Inventories-Debug] Ignoring optional share: last_location
[13:23:36 INFO]: [Multiverse-Inventories-Debug] Ignoring optional share: economy
[13:23:36 INFO]: [Multiverse-Inventories-Debug] Persisted: ender_chest, inventory_contents, armor_contents, off_hand, hit_points, remaining_air, maximum_air, fall_distance, fire_ticks, xp, lvl, total_xp, food_level, exhaustion, saturation, bed_spawn, potion_effects to WORLD:world (ProfileType:SURVIVAL) for player Benji_0224
[13:23:36 INFO]: [Multiverse-Inventories-Debug] Ignoring optional share: last_location
[13:23:36 INFO]: [Multiverse-Inventories-Debug] got data folder: plugins\Multiverse-Inventories\worlds\world from type: WORLD
[13:23:36 INFO]: [Multiverse-Inventories-Debug] Ignoring optional share: economy
[13:23:36 INFO]: [Multiverse-Inventories-Debug] Persisted: ender_chest, inventory_contents, armor_contents, off_hand, hit_points, remaining_air, maximum_air, fall_distance, fire_ticks, xp, lvl, total_xp, food_level, exhaustion, saturation, bed_spawn, potion_effects to GROUP:default (ProfileType:SURVIVAL) for player Benji_0224
[13:23:36 INFO]: [Multiverse-Inventories-Debug] Ignoring optional share: last_location
[13:23:36 INFO]: [Multiverse-Inventories-Debug] Ignoring optional share: economy
[13:23:36 INFO]: [Multiverse-Inventories-Debug] Defaulted: [ender_chest, inventory_contents, armor_contents, off_hand, hit_points, remaining_air, maximum_air, fall_distance, fire_ticks, xp, lvl, total_xp, food_level, exhaustion, saturation, bed_spawn, potion_effects] for Benji_0224 for WORLD:TESTER (ProfileType:SURVIVAL)
[13:23:36 INFO]: [Multiverse-Inventories-Debug] === Benji_0224 complete for WorldChangeShareHandlingEvent ===

Notice this line: [13:23:36 INFO]: [Multiverse-Inventories-Debug] No groups for toWorld.

commented

Thanks!

commented

Good work ben!

commented

Ok, I also realised why I couldn't reproduce the issue just now. This issue only occurs if the world is capitalised, i.e. TESTER instead of tester. I believe the issues is with some form of case sensitive checking of worldname that is not done correctly.