Support Spigot 1.12

Question

Support Spigot 1.12

zombachu opened this issue 8 years ago · 12 comments

zombachu commented 8 years ago

1.12 removed the deprecated version of YamlConfiguration.loadConfiguration() that took InputStream as a parameter. Problem line here

fernferret · Answer 1 · 2017-05-20T16:52:05.000Z

I'll see about fixing this today/tomorrow.

zombachu · Answer 2 · 2017-05-21T00:14:06.000Z

Ah, my bad about creating a duplicate issue. My eyes must've skipped over the other one when I checked before making this one. Thanks for the quick update, though.

smmmadden · Answer 3 · 2017-05-22T12:43:27.000Z

Hi any update on when this will be fixed? Also, could you verify that if the plugin fails to load that it is not sending a shut down event to Spigot Server? I have 6 plugins that fail and the server shuts down and according to Spigot, its "a plugin" that is the cause. I've reported on the other 5 plugin pages and now this one. :-) Thanks!

fernferret · Answer 4 · 2017-05-22T15:39:34.000Z

I did not get a chance to look at this during the weekend, sorry. To be clear, I don't think it's a big fix at all (should be easy) but I just ran out of time.

…

On Mon, May 22, 2017 at 6:43 AM, Steve Mekkelsen Madden < ***@***.***> wrote: Hi any update on when this will be fixed? Also, could you verify that if the plugin fails to load that it is not sending a shut down event to Spigot Server? I have 6 plugins that fail and the server shuts down and according to Spigot, its "a plugin" that is the cause. I've reported on the other 5 plugin pages and now this one. :-) Thanks! — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#457 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAEca-CQofj8hNHVvwNU3fPrHgIMvKXdks5r8YLvgaJpZM4NhNG6> .

Jeppa · Answer 5 · 2017-05-23T16:03:46.000Z

You 'just' have to replace the call
YamlConfiguration.loadConfiguration([InputStream])
with
YamlConfiguration.loadConfiguration([InputStreamReader])

but that needs some more code to be added...
I had to do this with some of my plugins aswell.

fernferret · Answer 6 · 2017-05-23T17:03:39.000Z

Yep, I hear ya. I'd been slacking (for the past few years haha) on keeping the sub components up-to-date. Y'all have *not* been forgotten and I will get to it sometime this week, not sure when though...

…

On Tue, May 23, 2017 at 10:03 AM, Jeppa ***@***.***> wrote: You 'just' have to replace the call YamlConfiguration.loadConfiguration([InputStream]) with YamlConfiguration.loadConfiguration([InputStreamReader]) but that needs some more code to be added... I had to do this with some of my plugins aswell. — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#457 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAEca-1tqP5QKq3eBG21-BOiXqdedyEpks5r8wNjgaJpZM4NhNG6> .

chrismin13 · Answer 7 · 2017-05-31T13:46:11.000Z

Done. Change line 245 to:

Configuration portalsDefaults = YamlConfiguration.loadConfiguration(new InputStreamReader(this.getClass().getResourceAsStream("/defaults/config.yml"), Charsets.UTF_8));

Also, add Spigot 1.12-pre6 to the pom.xml, but make sure it's at the top of the dependencies, otherwise it won't work.

Below is a compiled and tested version. Had trouble creating a pull request, so this will do for now. Enjoy!

Multiverse-Portals-2.5.0-SNAPSHOT.jar.zip

smmmadden · Answer 8 · 2017-06-01T02:41:29.000Z

@chrismin13 - looks like the build is missing from the plugin.yml
authors: ['Rigby', 'fernferret']
version: 2.5.0-SNAPSHOT-bUNKNOWN

fernferret · Answer 9 · 2017-06-01T06:21:10.000Z

Thanks @dumptruckman. I figure If I just keep saying I'm going to do something someone else on the team will actually do it :)

…

On Wed, May 31, 2017 at 9:21 PM, Jeremy Wood ***@***.***> wrote: Closed #457 <#457> via 3852d2a <3852d2a> . — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#457 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAEcawxQZHjSSjZi3GHlQTHBBL5yU_Izks5r_i4kgaJpZM4NhNG6> .

fernferret · Answer 10 · 2017-05-31T22:36:05.000Z

Saw the official is releasing this friday, so I guarantee this will be added to the baseline by then (hopefully tonight).

…

On Wed, May 31, 2017 at 7:46 AM, Christos Miniotis ***@***.*** > wrote: Done. Change line 245 to: Configuration portalsDefaults = YamlConfiguration.loadConfiguration(new InputStreamReader(this.getClass().getResourceAsStream("/defaults/config.yml"), Charsets.UTF_8)); Also, add Spigot 1.12-pre6 to the pom.xml, but make sure it's at the top of the dependencies, otherwise it won't work. Below is a compiled and tested version. Had trouble creating a pull request, so this will do for now. Enjoy! Multiverse-Portals-2.5.0-SNAPSHOT.jar.zip <https://github.com/Multiverse/Multiverse-Portals/files/1041688/Multiverse-Portals-2.5.0-SNAPSHOT.jar.zip> — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#457 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAEcaweeoyC5QfPrBtOskOPqUkoxQTbLks5r_W8kgaJpZM4NhNG6> .

TheRealB · Answer 11 · 2017-06-01T19:39:37.000Z

Maybe its possible to start an build process on the jenkins?

dumptruckman · Answer 12 · 2017-06-01T23:51:15.000Z

Weird. Not sure why it didn't build automatically. I just triggered a build now.

Share to