Multiverse-SignPortals

Multiverse-SignPortals

367k Downloads

signportals [mv] pl:<player>

h0us3cat opened this issue ยท 6 comments

commented

When players have "- multiverse.signportal.validate and- multiverse.signportal.create" they can make signs with [mv] pl:.
I tried with a negative permission "- -multiverse.teleport.other.pl and - -multiverse.teleport.self.pl"
With these permissions they can still make/use them.
Using cb 1337, mv core 326, mv-signportals 129.

commented

Aight, I'll have to investigate this tonight. Thanks for the report.

Few more questions:

  • What Perms system?
  • Have you tried using /mv check NAME pl:BLAH If this returns yes, then the permissions themself are most likely at fault.
commented

I can verify there is at least some problem with this.

Steps to reproduce:

  1. Install CB 1565, Core RJ-001, SignPortals UNKNOWN, and PermissionsBukkit 1.2k
  2. Grant a user the following permissions:
    • permissions.build
    • multiverse.signportal.validate
    • multiverse.signportal.create
  3. Deny that user the following permissions:
    • multiverse.teleport.other.pl
    • multiverse.teleport.self.pl (for completeness)
  4. Log in as the user and get a sign
  5. Build a sign with second line [mv] and third line pl:aplayer
  6. Right-click the sign

Expected results: the player is denied permission to either create the sign or use it (either should suffice, though the original bug really wants both to fail).

Actual results: the action throws an NPE, as logged here.

Further notes: I couldn't actually test with MV-Core 326, due to the whole Jenkins thing, so the NPE might be tangentially related at best; even so, this is worth looking into.

commented

@fernferret
I use pex and /mv check NAME pl: reports
"NAME can travel to pl:player"

commented

@h0us3cat: I actually can't reproduce that particular result. Using the steps above, I still produce the NPE (most likely because my target player is myself), but mv check lithium3141 pl:lithium3141 says that I can't travel to myself. Can I ask for the full command you use to check, with NAME and other such placeholders swapped out for actual data?

commented

By the way, I'm calling this the only blocker for 2.2. Go go team testing!

commented

@lithium3141 yeah pl:ownname gives "can't travel to myself" but i used 2 different accounts :)