MyDog

MyDog

8k Downloads

Volume Control

OojinJi opened this issue ยท 4 comments

commented

Feature description

Hi, I couldn't find the config if there is one, but the dog leveling up is really loud, and I was wondering if there was a way to lower it.

How the feature is useful

I will help people with sensory issues.

commented

Hi there!

Thanks for the feature request.
The sounds in Minecraft, at least to my understanding, are already limited and usually play at the "highest volume". Anything above 1.0 just does so the sound can be heard from further away.

Currently, the sound has a "volume" of 3.0, and I don't believe that it would be worth it to add a configuration option for this, as it would apply to every player, instead of just turning down each player's own volume in-game.

I will, however, leave the feature request open in case anyone else would like to implement the feature, or if this is a feature that multiple people would like to see happen in the future.

For reference, the sound is controlled here:
https://github.com/HeroGamers/MyDog/blob/df7c2bc7fa3e59cb6df2ccdea04bddaa2fcc8d10/src/main/java/dk/fido2603/mydog/managers/DogManager.java#L396C69-L396C69

Best regards,
Hero

commented

So if i wanted too i just need to edit that line of code and rebuild?

commented

If so I will implement it it myself, thank you for the reply!

commented

You're welcome!
If you add it as a configurable option yourself and create a PR, then I'll merge it.
Otherwise, for now, I'll close as not planned.