OldCombatMechanics

OldCombatMechanics

46.1k Downloads

Gapples not giving saturation

Clijmart opened this issue ยท 7 comments

commented

Whenever you lose hunger and eat a gapple to refill it, it adds the 2 hunger bars like it should, but does not add to your saturation. This means whenever you walk or anything after that, you will lose hunger rightaway.
This is quite annoying where you'd have to eat both gapples and normal food midfight, to regenerate your health enough.

commented

Can you try disabling separately the golden apples module and the player regen module and see if the problem is still present with either disabled?

commented

After some extra testing, we wrote down these:

When both the gapples and regen are enabled, it's broken.
When the gapples are off and the regen on, the hunger part works, but ofcourse the gapples aren't cuz disabled.
When gapples are on and the regen off, it doesn't work. Hunger goes down quickly.
When both are off, the hunger part works again.

After some more testing, we noticed it's only broken when you've lost health. When it tries to regenerate, it drains your hunger, even right after you gappled.
After you eat anything else, like steak or fish, it does fill your saturation however. So it's clearly something with the gapples / regeneration.

Hope this helped :)

commented

Ok that's great to have such information already so I can just concentrate on fixing the bug itself instead of working out what's not working. As soon as I have time I will fix this. Please ping me in a few weeks if I forget about it.

commented

You forgot about it? :P

commented

Well actually, I do not currently have time to work on this

commented

Ok @Clijmart I have managed to generate some time out of nowhere and work on this. I believe it is now fixed in test build 17. Please try the build and confirm so I can release the fix.

commented

Thanks a lot :)
We tested quite a bit, works perfectly!
Took us some time to notice why the configs kept resetting, we didn't update the config version to 25 :>

Awesome man <3