OldCombatMechanics

OldCombatMechanics

46.1k Downloads

Brewing Stand

linsaftw opened this issue ยท 38 comments

commented

Version of Bukkit/Spigot: 1.12.2 Paperspigot

Version of OCM plugin: 1.6.2

Default config.

No console errors.

The brewing stands doesnt refuel even with the world added to the list.

2017-11-12_20 39 04

Hope you can fix this soon :c all my 1.7 - 1.8 players cant make potions because of this.

commented

Did it used to work before?

commented

If you disable the old brewing stand module in the config does it work?

commented

No , never.

Do you have a estimated time for a fix-update? because everyone in HCF needs to make pots.

Thanks :)

commented

No... It never worked even disabling it.

Maybe it needs a recode... Is there a estimated date you can update and fix this? :(

commented

If the old brewing stand module is disabled, then it's not the fault of OCM, right @gvlfm78?

commented

If the old brewing stand module is disabled, I don't see how any other module would affect this...

The ultimate test, just to be sure would be to disable OCM entirely and see if the issue still persists

commented

It persists... what should i do? I want the old brewing stand :(

Btw Infinite lapis Enchantment table works ok but the brewing stand never worked.

commented

If disabling OCM doesn't make it work it means some other plugin is causing this...

You need to go through the list of plugins you have installed and look at which ones could possibly affect brewing stands, then disable each and check if brewing stand work

commented

OCM Old Brewing Stand doesnt work even without any extra plugins installed...

Im using Paperspigot 1.12 w/ProtocolSupport

Please i need a fix 1.7 and 1.8 players cant play HCF like this and they are leaving my server...

commented

What do you mean "OCM Old Brewing Stand doesnt work even without any extra plugins installed..."

as I said above, you need to first:

  1. Disable the module and see if brewing stands work normally
  2. Disable OCM and see if brewing stands work normally

I have no idea what you just did...

commented

Dude...

I tried the following things:

  1. Removed all the plugins and only letting OCM installed with OBS config enabled. Still 1.9.

  2. Brewing Stands are 1.9 even if the module is disabled or enabled with and without plugins.

  3. Reinstalling the plugin doesnt fix the issue.

What else do you want me to try? -.- that option doesnt have any effect on my server!

commented

So your problem is that 1.7 and 1.8 players cannot brew potions because it doesn't "refuel".
Unless your problem is "Brewing Stands are 1.9" regardless of the state of the module.
These are two completely different issues. What is your exact issue?

commented

The brewing stand is 1.9 means it isnt refuelling.

Im testing on 1.12 and i cant see the fire powder refuelling with everything i tried.

commented

and what is the behaviour for a 1.7/1.8 client?

commented

They want to brew the potions but they cant because the fire powder doesnt refuel. This happens on 1.12 aswell.

commented

but there is no "refuelling" behaviour in before 1.9, isn't there?

commented

In 1.8 SINGLEPLAYER brewing stands doesnt need fuel.

commented

So can 1.7 and 1.8 people use brewing stands or not?

commented

Dude can you be more clear with your questions? The refuelling doesnt work on 1.7 1.8 1.9 1.10 1.11 and 1.12 on my server. The server is 1.12 spigot with 1.7 - 1.12 support. I tried disabling all my other plugins and testing only with OCM installed still not working.

commented

I was going to ask you to be more clear with your answers because I properly don't understand what's working and what's not...

Also stop asking to 'fix it'; that's exactly what we're doing right now. I can't just press a couple buttons and make everything magically work, the first step is to know exactly what is not working.

commented

Im being really clear. No firepowder appears on the fuel slot. Thats all. Did you understand my answer? Do i have to be more specific?

No firepowder is appearing on the fuel slot when i have this option activated.

Even more specific?

When having the OLD BREWING STAND option activated on spigot 1.12 ProtocolSupport 1.7 , on all the clients (1.7 - 1.12) the firepowder doesnt regenerate on the fuel slot of the brewingstand.

commented

BUT, in 1.7 and 1.8, there was no such thing as refuelling a brewing stand. So how is it not being added/not working in those versions?

commented

Because the server is 1.12. The 1.8 - 1.7 players cant see the fuel slot so if it doesnt refuel they cant craft potions because they cant place fuel. Thats why i want a fast fix :(

commented

The fuel slot is server-side. Whether or not clients see it is irrelevant. If the fuel is present server-side, then the potions should brew. Are 1.9+ players getting the blaze powder automatically added to their brewing stands via OCM?

commented

I believe I changed the way that worked some time ago to automatically set the fuel level instead of adding blaze powder, in order to avoid item duplication issues

commented

Either way, are 1.9+ clients having their brewing stands fueled by OCM? If so, then it would still work for 1.7 and 1.8 players, as the fuel level of a brewing stand is entirely client-side.

commented

Why dont you understand what i say ;-; I said it doesnt work on 1.12 - 1.7 clients... (And yes i know its server-side xD but he was asking if this happened on 1.7 - 1.8 idk why)

I tried removing all plugins to check if a plugin was causing incompatibility but is still not working.

commented

Ah, okay. With the default OCM config, you said?

commented

I tried my config and the default.

commented

Could you upload your config so I can see what your options are?

commented

Hmm, true, with default config (old-brewing-stand enabled), I had to manually fuel the brewing stand with blaze powder. Bug confirmed, @gvlfm78.

EDIT: Just in case you want to know what I did, I set up a plain PaperSpigot 1.12.2 server with only OCM installed, and then logged on and pulled out a brewing stand. Nothing else. Would you like me to test with normal Spigot 1.12.2 as well? Although I doubt that would make a difference.

EDIT 2: Whatever, went ahead and did it, and the result was what I expected: same thing on normal Spigot 1.12.2.

commented

Is this something that broke with 1.12?

commented

Quite possibly. I have other things to work on, but I have a small theory as to why this isn't working. I'll keep you posted :)

commented

#144 -- there ya go!

commented

Is this going to be fixed? :/ 1.8 players want to make potions and they cant because the brewing stand isnt refueling

commented

Ok I have finally managed to get the Jenkins server back up. @linsaftw can you try the latest OCM test build and check if it now works as intended?

commented

Works good :D thanks! Fixed!