OldCombatMechanics

OldCombatMechanics

46.1k Downloads

Armor values missing / wrong

RainOfPain125 opened this issue ยท 13 comments

commented

version 1.6.3

if
old-armour-strength:
This is to set armour strength values as in pre-1.9
enabled: false

then my armor will have the normal armor values and normal armor toughness

if
old-armour-strength:
This is to set armour strength values as in pre-1.9
enabled: true

then my armor will have 9999 armor toughness HOWEVER will have no armor value (no armor points in the hotbar when wearing armor)

Setting it to true ultimately makes armor useless as it thinks you're not wearing armor

my full config - https://pastebin.com/ikNLGrhN

commented

Is this related to issue #154

commented

seems so.

commented

I'm not coder but from what he said build 18 works, but build 22 doesn't

In build 21 you added something that has something to do with data values (Simplified ItemData#hasMark (commit: 51baad4) (detail / githubweb))

maybe that's what you messed up? I can't shutdown my server (too many people on) or run a different server to test this (not enough resources)

commented

Ok I'm going to have a look at this at some point to see what the exact error is

commented

In fact, I did not make that change and @rayzr522 might know something more about what might be causing this issue

commented

@RainOfPain125 have you tried test build 22? Because I had that same problem on my server, but I fixed it in one of the commits after 1.6.3 was released. However, if they are not wearing the armor when you upgrade from the broken version to the fixed version, you may have to /ocm reload once they put it on.

Basically:

  1. Update to the latest test build (22)
  2. Put some broken armor on
  3. Do /ocm reload

Please let me know if that fixes things.

commented

I am using 1.6.3. If you mean there is a ver higher your wrong as that isn't the case on the jenkins page

Here is a video of me testing it some more -
https://www.youtube.com/watch?v=dDTbCof5Ae8&feature=youtu.be

commented

I'm saying to get build 22 on the Jenkins page, which is not 1.6.3. Are you using the latest version from the Jenkins page?

commented

I am on build 22 and /version oldcombatmechanics says it is ver 1.6.3 ...?

commented

Did you try putting some broken armor on and doing /ocm reload? Also, server logs would help.

commented

@RainOfPain125 This should now be fixed in version 1.6.5

commented

Even if it is I'll wait for you guys to smooth out the wrinkles in this plugin before I think about introducing old mechanics again. Too much PTSD for my players experiencing bugs from it :P

commented

All your current issues (other than the mcMMO problem) should be solved, but I understand. However, if no one were to use our plugin and find these bugs, we would never know about them :p