OldCombatMechanics

OldCombatMechanics

46.1k Downloads

Sweeping edge enchant doesn't work

iMaarten opened this issue ยท 9 comments

commented
  • Server version: 1.12.2 Paperspigot, build 1552
  • OldCombatMechanics version: 1.7.0(Latest dev Build)
  • OldCombatMechanics config file: https://pastebin.com/Kyfn2NAh

Problem Description

Sweeping edge enchant stopped working after updating from 1.6.3 to 1.7.0.

commented

What do you mean by "Sweeping edge enchant stopped working"?

commented

As in the enchant does nothing anymore.

commented

Well, you have the disable-sword-sweep module enabled, so it shouldn't be doing anything...

commented

Strange, it used to work just fine. Sorry.

commented

I put the warning IMPORTANT: Also enable disable-sword-sweep module or sweeps will have the damage value of the weapon in hand because I rewrote the way OCM checks for damage events. I made it not check if the event is a sweep attack and ignore it and thus the sweep damage goes wonky. Consequently, the disable-sword-sweep should be enabled when the other module is enabled. We can add the check into the damage generic listener event, but then most of the computation that occurs within the disable-sword-sweep module would always be going on, during any damage event.

commented

One more question is not possible to have the sweeping edge enchant working without having:
IMPORTANT: Also enable disable-sword-sweep module or sweeps will have the damage value of the weapon in hand
Build 1.6.3 seemed to do that.

commented

I mean, Sweeping edge quite literally does this:
grafik

If you disable sweeping attacks, what should it do?

commented

But normally they don't do as much damage, right?

commented

Okay, what do you want sweep attacks to do? And how do you want sweeping edge to influence it?