• Server version : 1.13.2
• OldCombatMechanics version : 1.7.3
• Server log file : https://pastebin.com/NnFcEWNk
• OldCombatMechanics config file : https://pastebin.com/BSxBALDc

Problem Description

Hi, I use OldCombatMechanics and a plugin known as MMOItems on my server. MMOItems allows for me to make special items that do configurable amounts of damage (as well as various abilities and things). However, with OldCombatMechanics installed, the damage for MMOItems doesn't work. Despite me setting the attack damage of a custom item to 100 damage, it will do the standard damage of that item. This only happens when OldCombatMechanics is installed.

Is MMOItems the premium resource on Spigot? I can't really check its code to see where the conflict would be if that's the case

Hey there, I'm the author of MMOItems. I've just added you to the buyers list so you should be able to download the resource and check its code. If you have any question about how MI handles damage, hop on my Discord. Anyways I might have an idea what the issue is (stg which has to do with attribute modifiers).

We are looking into this issue and it seems we have to take into account attributes when a damage event occurs.

Any progress? Not to seem pushy, I just want to plan if I will be able to start using OCM again... I have a temporary replacement thats kinda janky in right now... lmao

@kernitus correct me if I'm wrong, but we just need to add this as yet one more thing taken into account in OCMEntityDamageByEntityEvent.java, right? we already account for crits, potion effects, etc. just need to add attributes as something we check for, right?

@rayzr522 I believe it would also have to be calculated correctly before any modification is applied, and then re-added after OCM has done its thing.

Fixed with b177662