OldCombatMechanics

OldCombatMechanics

46.1k Downloads

Tool damage not working with QuantumRPG

RoloRotMG opened this issue · 47 comments

commented
  • Server version: 1.14.4 paper
  • OldCombatMechanics version: 1.7.4
  • Server log file: Nothing special here no errors
  • OldCombatMechanics config file:

Tool damage does not work properly on axes for me
image
Most axes do 9 damage no matter what i set it to. However if i set it to something more than 9 it will work
configexample.yml.txt

commented

If you enabled debug mode in the config.yml, what are the reported damage values when using axes?

commented
commented

I will need to see the OCM debug output.

commented
commented

image
this does 9 damage

commented

buuuump

commented

i really need this fixed soon

commented

@ElytraPvP sorry for the late reply. What other plugins do you have?

commented

Actually, seeing the output from EventChecker would help.

Just install it and do /listeners org.bukkit.event.entity.EntityDamageByEntityEvent.

commented

[19:29:12 ERROR]: Ambiguous plugin name OldCombatMechanics' for files plugins\OldCombatMechanics.jar' and plugins\OldCombatMechanics - 1.7.4.jar' in plugins' odd that i just got this error first time when oppening the server but i havent done anything haha

commented

That means you have two OldCombatMechanics JARs in your server folder. Delete both and re-download the latest dev build from the Jenkins build server.

commented

ive eddited the jar slightly

commented

I used 1.7.5

commented

Ive made it so the shield pops up on your screen when you right click with an axe and with a sword dont know if that would effect damage on axe though

commented

Feel free to keep a copy of the JAR you modified but for further testing we are going to need you to use a stock JAR. Otherwise we have no way to confirm it isn't an issue with a change you made or an issue with a bug that was patched after the version you modified.

commented

Alright Also i got this when typing the command
image

commented

Don't worry about the tab completion error, that should be fine. You can even just copy and paste the full command in if you want. Does actually running the command show you results?

commented

image
with the new jar it still does 9 dmg

commented

Can you not even run the command? That looks like just an error with tab completion (which is odd but still), it should not affect the actual running of the command.

commented

What should I do next

commented

Yes it said at the bottom i issued the command and there is no errors after that

commented

I need to see the output from the command... at the very least, it should list OldCombatMechanics' listener for the event.

commented

console has been empty since

commented

image
the second line is the output there is no console output

commented

image
these are the plugins atm

commented

How do you even know it's doing 9 damage? OCM's debug output showed it as doing 7

commented
commented

Not sure what's going on with EventChecker... maybe it's not compatible with 1.14.4.

But my guess is that quantum RPG is checking damage before OCM modifies it. You should actually test it with something else, such as a scoreboard objective that shows player health below the player name, and then see how much it decreases when you hit a player.

commented

I know its 9 damage i tested it with mobs either way quantumrpg shows damage if i increase the axe damage to like 20 it will say 20 its just when its under, very strange

commented

If you can make a minimum verifiable/working example (i.e. the minimal amount of plugins needed to reproduce this) I will have a look.

To do this, please try it out with just OCM and QuantomRPG and see if it stays at 9. If that works, I would add half of the other plugins, see if it is broken and then bisect it like that.

commented

Ill give it a go in a bit thank you

commented

Just tested it with essentials, ocm and quantumrpg and it still does 9 damage and the debugg text is indentical what should i try next

commented

I just noticed quantum RPG is paid.
I can not reproduce it on 1.14.4. Can you try this build, enable debug in the config and say what the yellow numbers are? You need to unpack the zip and there is a jar inside.

yellow numbers.

If you don't want to run some random jar, I will set up a CI job for it, so you can see where the code comes from.

commented

haha sure ill give it a go

commented

Also i tested it without qrpg and it works its just qrpg thats messing it up :(

commented

image
i set the damage in the config to 1 but it does 9 read this. When i dont have qrpg the orange text is 1

commented

Guess we will need to get in touch with QuantumRPG then...

Is there any option in that plugin to set tool/weapon damage? OCM is trying to play nice and sets the new damage right at the beginning, before other plugins should process the event.
If not, somebody needs to contact the QuantumRPG author and ask him about it.

@kernitus or @rayzr522 , do you wanna do that? My time is slightly limited by impending doom a math exam :)
For you: The golden text is the final damage from a MONITOR listener. So something alters the event after OCM has done its job, and that something seems to be QuantumRPG. I really gotta finish the event tracer upgrade when I have more time Rayzr :D

commented

hmmm it might also be JupiterCore its a dependency

commented

Would i be allowed to send a config of a payed plugin so we can give a look into it

commented

@ElytraPvP I guess we could have a look if there's any settings that would help

commented

Should i just upload it here?

commented

Here

commented
commented

Yes, or to Pastebin and then paste a link here.

commented

There seems to be a bit of overlap between OCM and QuantumRPG, for example these settings:

damage-formula: '%dmg% * ((1 + (%pvpe_dmg% - %pvpe_def%) / 100) * (1 - %block% / 100))' damage-reduce-by-cooldown: 0.0

It looks like it's changing the damage value after OCM has done so, @ElytraPvP do you know what the damage-formula is meant to emulate?

commented
commented

Well then I'm going to close this issue, if there are any further developements we can always open it again.