Information

• Server Version: Paper 1.15.2

• OldCombatMechanics version: latest

• Server Log File: -

• OldCombatMechanics config file: Any

Problem Description

Setting disable-player-crits: true in paper.yml stops working when I install your plugin. I ask you to fix this. Thank you in advance.

To Reproduce

Steps to reproduce the behavior:
1.
2.
3.

Expected Behaviour

Actual Behaviour

What does that setting normally do, and what is it instead doing? That's the purpose of the "expected/actual" behaviour section of the bug report...
Also, there's no such thing as 'latest' OCM version, please be specific... Otherwise we'll just be guessing at what the problem is and won't be able to help you.

It seemed to me that I wrote extremely clearly. Download the paper core and test it yourself. There is a Disable-player-crits setting in paper.yml. This setting remove crit from the weapon in the jump. If I install your plugin, then the setup stops working and regardless of true or false, the crits in the jump work.

Paper integrates these changes directly into the Minecraft entity attack method as seen here.
OCM ignores the default damage calculation and applies its own, ignoring that setting (seen here).

To fix that we could either provide that as an OCM option or detect if the server is running paper and figure out whether that setting is enabled. An OCM toggle would probably be a lot easier and less error prone.

Hi
there is still a serious problem with the critic (which does not accurately simulate pvp 1.8)
The problem intensified after the addition of "attack-frequency:" (excellent addition) which made the problem more noticeable.
I hope there is an update on this, I do not find any other serious problems like this in the resource.

Thank you so much for your time.