OldCombatMechanics

OldCombatMechanics

46.1k Downloads

Wrong resistance calculation

ludgart opened this issue · 4 comments

commented

Hey,

In the first video( https://streamable.com/hzw96o ), we can see an example of a strength 2 potion dealing damage to resistance 1 max armor player. After comparing it with the second video ( https://streamable.com/muxcdk ) where no resistance effect is in use, we can see that it reduces damage more than 50% which is an issue.

However, when there is no strength potion in use, the problem doesn’t appear and damage reduction is proportional to the effect of resistance.

Examples 3 ( https://streamable.com/a2gnh9 ) and 4 ( https://streamable.com/mn3ip3 ) show off that well with the first video being with, and the second one without resistance.

Server version: 1.16.5 (paper)
OldCombatMechanics version: 1.9.0

commented

@ludgart please try the new test builds, where I have rewritten most of the calculations that deal with damage.

commented

Closing due to rewrite of all damage calculation code. Please open a new issue with debug logs from the latest version if you think the issue is still present.

commented

I'm not sure what exactly you are trying to show here, isn't the strength potion supposed to double the damage in 1.8?

commented

Hey,

under normal circumstances, strength is supposed to do multiplied damage.

In the videos show here, when resistance effect is in play, the damage drops off drastically, much more than 20%.