OtherDrops

226k Downloads

PROJECTILE_ARROW doesn't check permissions

reallyimeric opened this issue · 6 comments

commented

like this:

ANY_CREATURE:
- tool: PROJECTILE_ARROW
drop: default
permission: explosionarrower
event: explosion
damagetool: 20

i have enabled pex debug mode.when i kill a creeper ,it doesn't check otherdrops.custom.explosionarrower

commented

oh..that‘s great..I want to design a group with permission "otherdrops.custom.explosionarrower”,that if a member of this group shot a creature,it will cause an explosion。but then i found that no matter who kill a creature,it will cause an explosion...then i enabled pexdebug,found it does not check the permission.
sorry for my english.....it’s not my first language... XD
and ,it seems that an earlier version of otherdrops does not have this issue(i‘m not sure if it is true).i couldn‘t remember the version。it maybe 2.6-beta1

commented

Yeah, that's because I fixed it :) In the previous versions permissions passed as true if it couldn't find a player - so it may have seemed to work but would actually never fail the check for permissions with a projectile.

You should be able to use PROJECTILE@PLAYER;(name) in the short-term if you want to give it to just a couple of people - working on the permissions check now but might be a day or two before I release a new build.

commented

Fixed (was easier than I thought) - here's a build (same as beta3 just with the permissions fix) to test. Please reopen the issue if there's any problems with it.

commented

fixed.Thank you!

commented

sorry it's my fault.
when i use other tool such as sword (i changed ”tool: PROJECTILE_ARROW“ to ”tool: ANY“),it checks otherdrops.custom.explosionarrower.
but i think when the tool is PROJECTILE_ARROW it should also check permissions of the attacker....

commented

Thanks for the report - you're right, PROJECTILE_ARROW should check permissions on the attacker, will look into that.