OtherDrops

226k Downloads

Compatibility issue with Regenblock

akitsaws opened this issue · 2 comments

commented

OtherDrops version:
CB 1.4.7-R1.0
RegenBlock version
1.4.7-R1.0

Description:
"It looks like by the time RB catches the event, block type is set to air, so they are not allowing blocks to break normally and overwriting event's values which messes up what RB can do." Regenblock plugin author

I think because of this it doesn't trigger the block break even needed for the other plugin to work

Config http://pastebin.com/ZQkzYj77

Steps to reproduce the problem:

  1. loading both plugins
  2. setting a custom drop change in a regenerating region

etc.

Expected result: ...
blocks will still be regenerated but it wont register them as broken so they don't regen back.
Other Comments:
This may be to much of a hassle to fix so I understand if there is nothing you can do about this. They use to work together but that may have been a few months ago.

commented

I've sent a message on the regenblock page: <<reply 1275634>>

Hi, thanks for looking into this. The default is to replace as that's the
most common use of OtherDrops, but OtherDrops allows for both adding new
drops and/or replacing default. If they are just adding new drops then the
event is not cancelled. Unfortunately, and this applies to any block drops
replacement plugin, the only way to cancel default drops is to cancel the
event, set block to air and drop the new stuff.

This causes problems with logging plugins too. I've supported a few of the
major ones by using their API to report the block break. Do you think this
would be possible with Regenblock? Something like
regenblock.regen(location) or .triggerBlockBreak(block)?
On 18/02/2013 5:01 AM, "akitsaws" [email protected] wrote:

OtherDrops version:
CB 1.4.7-R1.0
RegenBlock version
1.4.7-R1.0

Description:
"It looks like by the time RB catches the event, block type is set to air,
so they are not allowing blocks to break normally and overwriting event's
values which messes up what RB can do." Regenblock plugin author

I think because of this it doesn't trigger the block break even needed for
the other plugin to work

Config http://pastebin.com/ZQkzYj77

Steps to reproduce the problem:

  1. loading both plugins
  2. setting a custom drop change in a regenerating region

etc.

Expected result: ...
blocks will still be regenerated but it wont register them as broken so
they don't regen back.
Other Comments:
This may be to much of a hassle to fix so I understand if there is nothing
you can do about this. They use to work together but that may have been a
few months ago.


Reply to this email directly or view it on GitHubhttps://github.com//issues/127.

commented

Fixed - added support directly for RegenBlock in 2.8.