OtherDrops

226k Downloads

2.0 - check that all agents correctly set data to null (not zero) if not defined in config

Zarius opened this issue ยท 4 comments

commented

ToolAgent has been fixed - other agents need to be checked.

If data is set to zero then it will not match any other data value.

commented

I think some of the changes I made may partially fix this, since the Data classes were returning a SimpleData if they weren't able to parse it rather than returning null.

commented

I did this; several weren't setting to null. I haven't verified that the change didn't break anything else though. My changes will affect anything that uses the Data classes.

commented

I know both of us have fixed a few NPE's resulting from this change; not sure if they've all been caught, but should we close the issue?

commented

Sounds good, we can re-open if the issue arises again.