Pet Master

Pet Master

61.3k Downloads

Formatting error

oguh43 opened this issue ยท 13 comments

commented

Shift right clicking a owned dog displays "&OPet is owned by"...

commented

@oguh43 Hello I am sorry to hear that you are having issues. I will look into this and get it resolved. If you need anything else feel free to reach out and let me know.

commented

@oguh43 I have just released a new update that should fix this issue. Thank you for reporting and if you have anymore issues feel free to reach out again :D

commented

@oguh43 I have just released a new update that should fix this issue. Thank you for reporting and if you have anymore issues feel free to reach out again :D

Thanks :)

commented

Good stuff on getting your first update through @BigTallahasee ! ๐Ÿ‘

Two thoughts/observations:

  • the changelog on Bukkit seems broken. You probably can't copy-paste from Spigot directly, or maybe you need to copy-paste when in edit mode.
  • I would strongly recommend pushing changes to GitHub in small separate commits. It would be good to keep the project open-source and collaborative. Furthermore, the update checker relies on data on GitHub, and won't presently work for your update.

The workflow I used on this project was the following:

  • push all changes to GitHub as I went along, but only prepare the Increase version number to xxx locally.
  • submit the update to Bukkit.
  • wait until the update is accepted and live.
  • submit the update to Spigot by using the Bukkit download link - it's nice to point to the same unique download source (and also artificially increase the Bukkit download statistics :)).
  • push the increase version commit. At this point, users will be notified about the update and will be able to download on either Bukkit or Spigot.
  • do a tagged release via the GitHub UI.

Of course feel free to tune with what works best for you. Let me know if you have any questions. ๐Ÿ˜‰

commented

Thank you I will keep all of that in mind and start working towards that becoming a habit . :D

commented

Version 1.12.5 don't fix this issue.

commented

Switching to ยงo instead of &o in the source code should fix the issue.

I tried switching it here on github. It says that I have to be on the branch to make or propose changes

commented

The change seems to have gone through: f293edb ๐Ÿ‘๐Ÿป

You can also use GitHub desktop to help you out (https://docs.github.com/en/desktop/contributing-and-collaborating-using-github-desktop/making-changes-in-a-branch/committing-and-reviewing-changes-to-your-project), or do things through the command line. This training is quite fun and useful: https://learngitbranching.js.org/

commented

@seema84 I apologize that your are still having this issue. When I was doing testing there wasn't any formatting errors . Can you help me out by giving me a way to duplicate this issue? Thank you in advance have a great rest of your day!

commented

Hey @BigTallahasee, thanks for your reply.

I dont know if its relevant, i use the germany language file. https://github.com/PyvesB/PetMaster/blob/master/src/main/resources/lang-DE.yml

When I right-click on a wolf (not owned by me), for example, the first character displayed in the actionbar is "&O".

commented

its in
https://github.com/PyvesB/PetMaster/blob/4db543d9ede978367130ef93575e4f1d35c1e1c0/src/main/java/com/hm/petmaster/listener/PlayerInteractListener.java

	if (actionBarMessage) {
		try {
			FancyMessageSender.sendActionBarMessage(player, "&o" + ChatColor.GRAY
					+ plugin.getPluginLang().getString("petmaster-action-bar", "Pet owned by ") + ChatColor.GOLD
					+ owner.getName() + healthInfo);
		} catch (Exception e) {
			plugin.getLogger().warning("Errors while trying to display action bar message for pet ownership.");
		}
commented

Switching to ยงo instead of &o in the source code should fix the issue.

commented

Thank you :D