Plugman and mcore
Iceee opened this issue ยท 5 comments
What's the deal with mcore? What's wrong with it that's causing plugman to fail? Is it something I can create a branch for on my side? I run factions so I need mcore in order to work, but in the past mcore and plugman didn't have issues.
Is there an error associated with this? Most of the changes I've made have been house cleaning changes, I don't think anything I have done would explicitly break interaction with mcore. I'll take a look into this, however.
Well this didn't take long. I'm assuming the error you received is:
[12:28:36 WARN]: java.lang.NoSuchFieldException: knownCommands
This is because mcore injects it's own custom CommandMap. I'll add a temporary block for unload while mcore is running until I can implement a real fix (or support it) in the future.
Yes, that's the error. There's an issue open over at mcore regarding this subject but it doesn't look like they're going to change how they're doing it. Any way to work around this? Was the change that broke plugman + mcore working simultaneously on your end or on theirs?
I have tested with the previous stable release of PlugMan (1.8.4) and it still doesn't appear to be able to unload plugins with mcore enabled. No error as in the current dev version, but that's simply because I don't print the error to the console (in the old one).
Judging from the response in that issue, the mcore dev doesn't feel like supporting any other plugins nor does he seem to care, so it looks as if I'll have to add a work around eventually.
For the moment though, I'm just going to finish cleaning the code, make the existing unload work a bit better, and fix a few small things I've noticed within the plugin. That fix will have to come in a later version as it isn't directly my fault, and it will take a bit to fix if I still want to unload things rather than cover the error up. I will add a fix in time though, since mcore is such a large plugin and many users will overlap between us.
This has been fixed in the latest dev build available on my Jenkins server, thanks to a pull request by @ZeroErrors.