Hey,

Have been working on the plugin, I am now in the stage of debugging it. But I found something funny concerning one of the function in verctor.Field.

When I use .setDisabled(true) on a field, it will confirm that it is disabled. But when I use this on a godstone and set myself on fire... It will still heal me.

I am sure that my field is disabled, or at least the companion function isDisabled() says so.

Hope this can be sorted out .

Greetz,
Scriblon

(Tried to find the code that handles the healing of a player... But I couldn't find it anywhere ;), no listener, no task...)

Big NVM.
Making this ticket realized me that i mixed up the meaning of a 'true' in this case.

I've got some pending fixes locally. Check the latest tomorrow
On Nov 19, 2011 4:55 PM, "Scriblon" <
[email protected]>
wrote:

Hey,

Have been working on the plugin, I am now in the stage of debugging it.
But I found something funny concerning one of the function in verctor.Field.

When I use .setDisabled(boolean) on a field, it will confirm that it is
disabled. But when I use this on a godstone and set myself on fire... It
will still heal me.

I am sure that my field is disabled, or at least the companion function
isDisabled() says so.

Hope this can be sorted out .

Greetz,
Scriblon

(Tried to find the code that handles the healing of a player... But I
couldn't find it anywhere ;), no listener, no task...)

---

Reply to this email directly or view it on GitHub:
#110

I am sorry, but I am reopening this issue.
The debugging is almost done only for this one bug on the godstone I am testing it on.
When I disable it through this function it will still be functional. I can't really provide any proof except what I get from isDisabled.

(UpKeeper after Disabling) Field registered Disabled to ES : true
(UpKeeper after Disabling) Field registered Disabled to PS : true
(UpKeeper after Disabling) Field registered Disabled to ForeceFieldManager List : true

It only occurs when it is healing a player while I try to disable it.

Hope that these fixes, fixes this problems ;) .

Side note, testing is done with the 1337 build and mc 1.8.1

Additional info. It seems that the godstone disables after the player either dies, or when the chunks unloads.
Released plunging.

List of plugins?
On Nov 26, 2011 3:18 PM, "Scriblon" <
[email protected]>
wrote:

Additional info. It seems that the godstone disables after the player
either dies, or when the chunks unloads.

---

Reply to this email directly or view it on GitHub:
#110 (comment)

Maybe my previous comment wasn't really that clear. So let me recapitulate what I experienced when testing the setDisabled method.

When a godstone is curing a player while it depletes or gets disabled by the user (setDisabled(true)) it will still cure the player after my plugin disabled the field. Even when the player has been fully cured (and then hurt again to be healed).
But when the player dies, logs out, or the stone unloads by a server-reset or by unloading chunks... Then it will be disabled to that player.
I tried to find the code in PreciousStones which handles the curing-tag, to maybe anticipate on the problem. Unfortunate I couldn't.

My testing server has the next plugins:

• Essentials
• PreciousStones 7.0.6
• ExpensiveStones
• Spout
• Bukkit 1337

The problem persists outside my plugin. After deleting the ExpensiveStones plugin and testing my setup with only the godstone (slow-healing) the remains.

Meaning: The godstone will keep the player healing after its breaking.

Made separate ticket addressing the problem. link

Good explanation. I will fix this asap
On Nov 26, 2011 5:56 PM, "Scriblon" <
[email protected]>
wrote:

This persists outside my plugin. After deleting the ExpensiveStones plugin
and testing my setup with only the godstone (slow-healing) the problem
still persists.

Meaning: The godstone will keep the player healing after its breaking.

Made separate ticket addressing the problem. link

---

Reply to this email directly or view it on GitHub:
#110 (comment)

fixed on 7.1.3