PreciousStones

PreciousStones

269k Downloads

Bugged "/ps hide"

kbryant opened this issue · 22 comments

commented

When a player uses "/ps hide" on their protection stone, and then tries to break it, the block doesn't drop when it's hidden. The protection is removed but they don't get their block back. It works fine when it's not hidden, but it's bugged when hidden.

commented

Does this happen always? Or in certain situations, or with certain block types?

commented

It always happens. My config:

http://pastie.org/5625454

commented

...And using CB 1.4.6-r0.3, PS 9.5.4-SNAPSHOT

commented

I just tested this. I can't even place the protection blocks anymore. When I place my Diamond Block down, it doesn't even say or register anything. It's as if I'm placing it normally. Do you have an instant messager handle that I can message? Because there's other issues as well with your most recent builds (/ps locations and /ps counts aren't matching the number of protections a player has placed. I have a "limits" setup in the config and players are reporting that it's saying that they have reached their maximum of 5, even though they've only placed down 3).

commented

Regarding the "limits" problem. I verified that the player has not yet reached their maximum number of protections they can place with an SQLite browser. Yet it says they have reached their limit when they try to place.

commented

I just tried your "Build #181". I can now place and break Protection Stones successfully. "/ps clean " returns results saying it has cleaned some orphans... But now there's still one issue remaining:

I have performed a "/ps delete " to delete all my fields. It deletes them all. I execute "/ps locations" and see "No fields found", as expected. I even verify with an SQLite browser to make sure I have no records in the database. No records found. BUT, when the player types "/ps counts", it shows 3 counts for protectionBlock_A, and 2 counts for protectionBlock_B...

I hope this helps!

commented

Getting closer... Build #182 now counts stones correctly. "/ps counts" and "/ps locations" match. So say my Player has 3 of protectionBlockA, and 2 of protectionBlockB. "/ps counts" and "/ps locations" show this correctly. I even view the database with an SQLite browser and see the 5 records from this player.

Now, if I do a "/ps clean ", it deletes all of that specific player's protection blocks. After running the clean, "/ps counts" and "/ps locations", it says there's no PS stones. I even look at the database with the SQLite browser and the 5 records are now gone.

commented

So /ps clean is deleting everyones fields?

On Sat, Jan 5, 2013 at 3:14 AM, kbryant [email protected] wrote:

Getting closer... Build #182https://github.com/SacredCoding/PreciousStones/issues/182now counts stones correctly. "/ps counts" and "/ps locations" match. So say
my Player has 3 of protectionBlockA, and 2 of protectionBlockB. "/ps
counts" and "/ps locations" show this correctly. I even view the database
with an SQLite browser and see the 5 records from this player.

Now, if I do a "/ps clean ", it deletes all of that specific player's
protection blocks. After running the clean, "/ps counts" and "/ps
locations", it says there's no PS stones. I even look at the database with
the SQLite browser and the 5 records are now gone.


Reply to this email directly or view it on GitHubhttps://github.com//issues/511#issuecomment-11911495.

commented

I just tried this with a different player who was not experiencing the "/ps count" and "max protections" mismatch issue. No, "/ps clean" is not deleting everyone's fields. It however deleted that specific player's fields.

commented

My wording was awkward, let me rephrase.

PlayerA reported that he was seeing the "max protections reached" message, even though his "/ps counts" told him he wasn't at his max yet. Your recent builds just now fixed that. However, "/ps clean " is deleting all his fields.

PlayerB didn't report that issue. She had 1 protection block down already. "/ps counts" and "/ps locations" show that. However, "/ps clean " is NOT deleting her existing fields.

commented

Could it be that his fields were orphaned and thats why /ps clean deleted
them? Can you test adding new fields and cleaning to see if they get
deleted?

On Sat, Jan 5, 2013 at 3:23 AM, kbryant [email protected] wrote:

My wording was awkward, let me rephrase.

PlayerA reported that he was seeing the "max protections reached" message,
even though his "/ps counts" told him he wasn't at his max yet. Your recent
builds just now fixed that. However, "/ps clean " is deleting all his
fields.

PlayerB didn't report that issue. She had 1 protection block down already.
"/ps counts" and "/ps locations" show that. However, "/ps clean " is NOT
deleting her existing fields.


Reply to this email directly or view it on GitHubhttps://github.com//issues/511#issuecomment-11911560.

commented

If they were orphaned, would they show up under "/ps locations"? What exactly is the definition of an "orphaned" field?

commented

Yea they would still show, an orphaned field is a field on the database
that doesn't have a field block on the actual world. Could be that the
server crashed and reverted the world, or the block got deleted using
superpickaxe or another plugin wiped the blocks out in the world without
letting PS delete them from the database. So basically they are phantom
fields that don't have a block to represent them. They would show up on
counts, /ps info, and have the effects of the field, but no block to be
found.

On Sat, Jan 5, 2013 at 3:26 AM, kbryant [email protected] wrote:

If they were orphaned, would they show up under "/ps locations"? What
exactly is the definition of an "orphaned" field?


Reply to this email directly or view it on GitHubhttps://github.com//issues/511#issuecomment-11911588.

commented

Ahhh! Then they are most likely all orphaned fields then. My test server's world map is about a month old from my live server's map. These out-of-sync block count issues may finally be fixed then.

However, one more little one from the recent builds:

After placing a protection block down, when I break down the block, the protection is removed, however it also says "Your account has been credited" and the block reappears. The "/ps counts" and "/ps locations" seem like they updated correctly. I have to break it again to get the block to drop.

commented

Odd, try removing all non-essential plugins and see if you have the same
problem, could be a plugin conflict?

On Sat, Jan 5, 2013 at 3:35 AM, kbryant [email protected] wrote:

Ahhh! Then they are most likely all orphaned fields then. My test server's
world map is about a month old from my live server's map. These out-of-sync
block count issues may finally be fixed then.

However, one more little one from the recent builds:

After placing a protection block down, when I break down the block, the
protection is removed, however it also says "Your account has been
credited" and the block reappears. The "/ps counts" and "/ps locations"
seem like they updated correctly. I have to break it again to get the block
to drop.


Reply to this email directly or view it on GitHubhttps://github.com//issues/511#issuecomment-11911647.

commented

You know what? That happens in the world spawn area protected by bukkit.
Walk farther out the map and try again.

On Sat, Jan 5, 2013 at 3:40 AM, Phaedrus [email protected] wrote:

Just tested the build and its not happening to me.

On Sat, Jan 5, 2013 at 3:38 AM, Phaedrus [email protected] wrote:

Odd, try removing all non-essential plugins and see if you have the same
problem, could be a plugin conflict?

On Sat, Jan 5, 2013 at 3:35 AM, kbryant [email protected] wrote:

Ahhh! Then they are most likely all orphaned fields then. My test
server's world map is about a month old from my live server's map. These
out-of-sync block count issues may finally be fixed then.

However, one more little one from the recent builds:

After placing a protection block down, when I break down the block, the
protection is removed, however it also says "Your account has been
credited" and the block reappears. The "/ps counts" and "/ps locations"
seem like they updated correctly. I have to break it again to get the block
to drop.


Reply to this email directly or view it on GitHubhttps://github.com//issues/511#issuecomment-11911647.

commented

Just tested the build and its not happening to me.

On Sat, Jan 5, 2013 at 3:38 AM, Phaedrus [email protected] wrote:

Odd, try removing all non-essential plugins and see if you have the same
problem, could be a plugin conflict?

On Sat, Jan 5, 2013 at 3:35 AM, kbryant [email protected] wrote:

Ahhh! Then they are most likely all orphaned fields then. My test
server's world map is about a month old from my live server's map. These
out-of-sync block count issues may finally be fixed then.

However, one more little one from the recent builds:

After placing a protection block down, when I break down the block, the
protection is removed, however it also says "Your account has been
credited" and the block reappears. The "/ps counts" and "/ps locations"
seem like they updated correctly. I have to break it again to get the block
to drop.


Reply to this email directly or view it on GitHubhttps://github.com//issues/511#issuecomment-11911647.

commented

What is the "Your account has been credited"? I am not charging or refunding. My config:

http://pastie.org/5625454

commented

Which field did you break?

On Sat, Jan 5, 2013 at 3:43 AM, kbryant [email protected] wrote:

What is the "Your account has been credited"? I am not charging or
refunding. My config:

http://pastie.org/5625454


Reply to this email directly or view it on GitHubhttps://github.com//issues/511#issuecomment-11911702.

commented

Emerald Block, 133 is exhibiting the problem. Diamond Block is not.

commented

I went on my live server, which is using PS 9.5.4 that you posted on your main page. The Emerald Block reappears, but doesn't show the "credited" message.

commented

Your latest build #185 fixes the "credited" message, however the Emerald Block is still reappearing after breaking it once. If I place the Diamond Block in the exact same spot, it breaks fine in one break.