PreciousStones

PreciousStones

269k Downloads

presious stones removing added players

bknysnake opened this issue ยท 19 comments

commented

hey I thought this update would fix this but it appears to still be there, when a player adds another player to their ps stone using "/ps allow (playername)" it seems to work, but after a restart, it appears to have romoved that player who was added, I'm trying to figure out if it's a bug on our end or your end, but I can't seem to track it on our end, I've got the latest update, and it still seems to do the same problem. after adding a player, and the server restarts the player is removed from the ps stone.

commented

I'm having the exact same issue, using spigot 844 with PreciousStones 297.

commented

Same issues here, players are randomly dropped from allowed lists upon restart.

commented

Same issue here. When manually adding a name to the database, it works fine, but any changes made ingame are lost when the server restarts. Running CraftBukkit build 2771 (the latest beta, at the time of writing) and PreciousStones build 297 (the latest build from Jenkins, at the time of writing).

commented

I'll be investigating this tomorrow.

commented

I would like to second micahdg on his issue as we run a few servers together, this post is really to confirm the problem xDthanks for any and all help:)

commented

Hahaha BK, you know YOU wrote the opening post, right? :)

commented

This is also happening with the /ps changeowner command.

commented

When a player is adding in-game have you checked the database to see if it got saved there before restarting the server? What I need to know is if the player is removed from the database when it restarts, or if he never gets saved there in the first place. Also what kind of restarting are you doing, is it clean restarts?

After you verify that, try setting the saving.frequency-seconds setting to 1 second, see if the problem goes away.

commented

After doing some more testing I can't say one way or another, sometimes it saves them to the packetsallowed, sometimes it doesn't, sometimes if you add one person and they don't show up in packetsallowed if you add another person both people show up. But from the looks of things the people having trouble never have their friends names added to the database in the first place.

commented

We tested with some of our problem stones before making the change you suggested.

First stone, using /ps setname Lobby to change the name of the field:

Query prior to /ps setname Lobby:
'2450', '7233', '77', '28935', 'world', '20', '256', '0', '57', '0', 'chipw', 'Chip and Jenny's Mooshroom Island', 'c:bnvs|kc8mat|matti4464|preuss100|camelj2486|somehobo365|anders2992|somasakamoto|egijr|experiencedgamer|some1else0|chipolte|s346911|zeerupo|thomasbjo|o0flint0o|tteeddyy|matti44|andreasbjo|rawfish02|blazingdragon100|yugioh79|thoatt|zombiepigman2x2|arich|michahcb|micahcb|famcrafthobo|teddibear126|rundrop|tteddyy|jessepoo|frenchtoast77|vbopgirls', '1364688265488', '{}'

Query after /ps setname Lobby
'2450', '7233', '77', '28935', 'world', '20', '256', '0', '57', '0', 'chipw', 'Chip and Jenny's Mooshroom Island', 'c:bnvs|kc8mat|matti4464|preuss100|camelj2486|somehobo365|anders2992|somasakamoto|egijr|experiencedgamer|some1else0|chipolte|s346911|zeerupo|thomasbjo|o0flint0o|tteeddyy|matti44|andreasbjo|rawfish02|blazingdragon100|yugioh79|thoatt|zombiepigman2x2|arich|michahcb|micahcb|famcrafthobo|teddibear126|rundrop|tteddyy|jessepoo|frenchtoast77|vbopgirls', '1364688265488', '{}'

Our saving frequency is currently 15 seconds. I waited a few minutes and checked the database again. Still no change. No overlapping PS fields in the area.

Another stone, actually a pile of the same stones, placed yesterday by a clan leader. Normally when a clan leader places PS, their clan is automatically allowed in the PS field. Specificalyl, c:cielo is added to the packed_allowed field. After a normal clean nightly restart, c:cielo was dropped from all the PS flields placed in the pile:
'4570', '-448', '47', '161', 'world_the_end', '20', '257', '0', '57', '0', 'RubensCherub', '', '', '1368849043058', '{}'
There were no other player's PS fields in the area. A clean restart happened between the time the player placed the stones, and right now when I am checking them.
I just now ran /ps allow c:cielo on the PS. C:cielo is now listed, however a database query of the pstone_fields table shows no change:
'4570', '-448', '47', '161', 'world_the_end', '20', '257', '0', '57', '0', 'RubensCherub', '', '', '1368849043058', '{}'

And a third stone:
'2016', '62137', '64', '-20761', 'world', '20', '256', '0', '57', '0', 'Aw3Som3xRaGE', '', 'c:cielo', '1364688264445', '{}'
We have to re-add a player, Eloquent_Elixir, after every clean restart.
Running /ps allow Eloquent_Elixir and then /ps allowed shows Eloquent_Elixir as added, but no update to the database.

And finally, some stones, specifically older stones, do not give us any kind of problems when adding and removing players, changing field names, etc.

Now, I changed the saving frequency to 1 second, reloaded the config, made changes to some problem stones, no update to the database, even after several seconds.

I'll try again after the clean nightly restart.

commented

Okay, after the clean nightly restart, the names that were allowed to the stones before the restart are still not in the database and they are dropped from within the game. They all had to be added again ingame, and doing so still does not update the database.

By the way, if it helps, we were having the same problem while using sqlite. We imported the sqlite db into mysql last week and this problem persists.

Today I will pick some random old stones and add allowed players to them and check them tomorrow to confirm whether there's really a distinction between old and new. I will also pick some by other arbitrary means such as stones placed 1 per month for the last year, 1 from from each group of 1000 stone IDs in the database, etc. Nothing else I can imagine we can do on our end to help :P

commented

While continuing to mess with older stones, I've again run into what nineieve mentioned above:
#590 (comment)

With the stones that won't correctly immediately add a new player to the packed_allowed field in the database (pstone_fields table), I am able to replicate this over and over. First I /ps allow yoyoyo and then check the database. No update (saving frequency is still set to 1 second). Then I /ps allow hahaha and check the database, BOTH names are now included in the packed_allowed field. Additionally, after adding the second name, I'm then able to remove and add additional names at will with immediate updates to the database.

I'm tracking these stones and will check their status again after the clean nightly restart.

commented

lol yes I know but I'm trying my best to get this fixed :P I love PS!!!!

commented

Here's what I think is the pertinent info:
http://paste.kealper.com/view/1plJNWsH

Here's everything from when I turned on debug, till 10 minutes later:
http://paste.kealper.com/view/oOEH7XQc

commented

Perfect that you tracked these specific stones down. Can you turn on /ps debug, which will output the SQL to the console, and then try to add a name so that it fails to get into the database. See anything wrong with the update statement, is one even being sent out?

commented

I would try on our server but we are currently under a massive DDoS attack :(

commented

Perfect, thank you. This will help.

commented

After a clean restart, the names that were added after adding 2 names (1 at a time) are still in the database and show ingame. We will keep following this process until whatever's causing this gets fixed.

commented

Any progress on this? It is game breaking for a lot of players.

Both /ps allow and /ps changeowner are doing this.

Thanks!