PreciousStones

PreciousStones

269k Downloads

Incompatibility with CombatTag plugin

tmariovlad opened this issue ยท 2 comments

commented

PreciousStones is no longer compatible with CombatTag plugin (http://dev.bukkit.org/bukkit-plugins/combat-tag/). If you have both installed on a 1.7.2 server and you try to hit a player in a pvp-disabled area, PreciousStones will generate an error: "Could not pass event EntityDamageByEntityEvent to PreciousStones v9.6.5-SNAPSHOT"

In the file "net\sacredlabyrinth\Phaed\PreciousStones\listeners\PSEntityListener.java" there are a few lines of code which generate the error:

if ((this.plugin.getCombatTagManager().isInCombat(attacker)) && (this.plugin.getCombatTagManager().isInCombat(victim)))
    {
    this.plugin.getCommunicationManager().warnBypassPvPDueToCombat(attacker, victim);
    return;
    }

The api for CombatTag has changed as seen here: http://dev.bukkit.org/bukkit-plugins/combat-tag/pages/using-the-api/
So the check in PreciousStones should be changed too, to fix the problem.

commented

Find the latest build in my Jenkins.

commented

Thanks, bug fixed. ๐Ÿ’ƒ