ProtocolLib

Bukkit Plugins
3M Downloads

The log redirect handler does not take log message parameters into account

blablubbabc opened this issue ยท 0 comments

commented

ProtocolLib Version: 4.8.0-SNAPSHOT-b539

ProtocolLib/src/main/java/com/comphenix/protocol/ProtocolLib.java

Line 323 in 4bc9e8b

commandPacket.broadcastMessageSilently(record.getMessage(), permission);

This prints the raw, unformatted log message.

I noticed this when some other plugin accidentally forgot to relocate bundled classes which ProtocolLib then loaded, which resulted in this warning by Spigot to be logged (with placeholders properly replaced), and then broadcasted by ProtocolLib via this redirect handler in-game, without the placeholders replaced: [ProtocolLib] Loaded class {0} from {1} which is not a depend, softdepend or loadbefore of this plugin.

Also, not sure if some plugins actually make use of localized messages via an attached ResourceBundle, and if this is something to take into account by this redirect handler as well. But if yes, one option could be to use a SimpleFormatter to format the LogRecord.