This: 073bfa2 breaks BuyCraft completely.

https://pastebin.com/raw/8d7FS14A

Rolling back to build 548 = all is functional.

Perhaps the same root issue (if not I will open another): On both 1.18.1-3443 and 1.18.2-3453, with lots of plugins (it's a plugin test server) all up-to-date bleeding-edge dev builds, ProtocolLib 5.0.0-b549 blocks connectivity completely. The servers do not even register in the client. Reverting resolves the problem.

Hey, thank you both for reporting/confirming issues with the new version. Honestly I was already expecting some plugins to break over the change...

@andrewkm I will look into the BuyCraft code later today and try to figger out if they did something stupid or if we did!
@SlimeDog if you have any other exceptions thrown when starting the server with v5 over v4 then feel free to post them here as well, that way I don't have to look into multiple issues or lose track over them 😂

Update: that was easier than I thought, especially because they use the exact same code as ProtocolLib did before the rewrite (even the field names are equal 🤔 ). Looks like we accidentally fire the channel init down the pipeline twice, will look into that today!

Will do. There are no exceptions (on my test servers) with 5.0.0-b548 on Spigot or Paper 1.18.2, but my use cases are limited at the moment, since we are in a development cycle for a new plugin.

@andrewkm does that happen every time?

Yes.

I am not seeing those issues on shutdown on Spigot or Paper 1.18.2. Shutdown is much slower than previous MC versions. Note that I have set settings. timeout-time: 240 in spigot.yml. Otherwise, I got huge timeout issues on shutdown, saving default world.

I'm a bit confused as I am not able to reproduce the issue, even on the exact same server version you are using (unless it is a custom fork of paper...)

Very likely it is related to plugin load. I did not have shutdown problems with just a few plugins (mostly Multiverse-* and my own plugins), but when I added our full 160+ plugin test suite, the problems became severe. It was resolved -- once some key plugins were upgraded to support 1.18.2 -- only by increasing the timeout. In my experience, the shutdown/timeout issue is less severe on Paper, probably due to async chunk protocols, but still exists.

Found the issue and fixed it, thanks for your report! See https://github.com/dmulloy2/ProtocolLib/suites/5595558993/artifacts/181561818 for a version you can test :)

Thanks. Quick work.

We have other things on the plate with our own development. I will probably wait for the dev build.

@derklaro a quick test shows BuyCraft being fixed, however the server shutdown process is still wonky...
https://pastebin.com/raw/i1CtkUJB

We are running 1.17.2 build 409 (latest that was released).

FWIW, I think you mean Paper 1.17.1-409.

Yeah that lol, 1.18.2 has me brainwashed.

Still seeing issues with b550 on Spigot/Paper 1.18.2 latest builds. I am away from the servers atm, but if no one else posts overnight (here), I will.

Can you specify more? This issue was closed as the cause of it was fixed... Does the same issue persist? Or are you referring to other issues? 🤔

It's probably a different problem, but it was reported to me verbally. If so, I will open a new issue.