ProtocolLib

3M Downloads

1.19 Dev Builfd

matipoirierg opened this issue · 18 comments

commented

I've been testing 1.19, with the 567 protocollib build. I have an issue, my server tps drops to 0.3 (yes, that laggy) because of protocolib.
https://timings.aikar.co/?id=1f72d716285e4b86972a05d03d7b3603#

commented

This happened to us as well. It started happening with build #566. Build #565 works without any issues. (Commit: 4db1e39)

commented

Again, please attach a spark profile result so that I can analyze and resolve the issue 🤔

commented

So I just did a quick test so and cannot reproduce this, please provide more information in order for me to help :/
image

commented

Hopefully this will help you finding the cause of the issue. https://spark.lucko.me/ylIKIBxwIQ

It is somehow connected to PremiumVanish plugin, but this issue started happening after commit 4db1e39 (Build #566).

commented

Can you also attach the protocollib dump? (/protocol dump)

commented

Here you go. Let me know if you need something else
dump-2022-06-12_15.51.09.txt
.

commented

Please use spark to attach performance metrics, timings are not helping at all

commented

I also had insane TPS drops with the latest official dev version on 1.19 (basically looping to death), tried this last posted version above this post now and it for now seems to be resolved, Ram usage is normal, tps constant 20, Paper mspt around same values as 1.18 server version, no issues with plugins hooking into Protocollib.
Will update if any errors occour, but as said, seems to be fixed, at least for me, for now!:)

commented

I wasn't able to reproduce this, but after looking closely at the commit again I noticed that the check if the packet write was actually called from the event loop was missing (I am 100% sure I had that check, but I removed it again or smth)... Could you please test if the issue still persists with https://github.com/derklaro/ProtocolLib/suites/6897607157/artifacts/267594273 ?

commented

I had the same issue with extreme lags and did some profiling, it is mostly that com.comphenix.protocol.injector.PacketFilterManager.getEntityFromID() now is horrible slow, the previous version of protocollib i used (some build from early 1.18.2) did not have this issue.

commented

This is definitely not related to this issue, but being worked on: #1566

commented

This is definitely not related to this issue, but being worked on: #1566

Ok, thats great, i had to remove protocollib and all dependent plugins for now.

commented

He is. Unforntanetly I cannot see the source code of it, so it's a bit hard to track down the issue :/ - will give it a shot again now

commented

I wasn't able to reproduce this, but after looking closely at the commit again I noticed that the check if the packet write was actually called from the event loop was missing (I am 100% sure I had that check, but I removed it again or smth)... Could you please test if the issue still persists with https://github.com/derklaro/ProtocolLib/suites/6897607157/artifacts/267594273 ?

This issue is still happening with this build.

commented

I'm sorry I can't make a spark timing right now, not in my home, but I think the issue is caused by PremiumVanish, @MrRockis Do you use premium vanish?

commented

Okay, after giving it some attempts to reproduce it seems that I actually found the issue: PremiumVanish seems to clone some packets during sending which marks them incorrectly as non-processed causing an infinite loop. I've fixed that now, could you please give https://github.com/derklaro/ProtocolLib/suites/6899303438/artifacts/267710223 a try?

commented

Hello, I have a problem on my server with Lag, TPS is lowering to 15 and MSPT going over 70, all sparks accuse ProtocolLib as the cause of the lag, but I've tried everything but the lag continues, it does This has been happening for about 2 weeks.
Could anyone help?
ProtocolLib is up to date with the latest Dev Build, and Purpur is up to date on 1.19 and the latest update.
https://spark.lucko.me/ouLYG9rxIZ

commented

Sem título