ProtocolLib

3M Downloads

Using MonitorAdapter breaks server ping [1.19.x]

KosmX opened this issue ยท 4 comments

commented
  • This issue is not solved in a development build

Describe the bug
When registering a MonitorAdapter packetlistener, server ping won't work.

To Reproduce
Steps to reproduce the behavior:
Create a plugin implementing ProtocolLib. you may use an older Emotecraft plugin build....

Load 1.19 server (paper or purpur tested)
From client (or mcstatus command) ping the server.
The ping won't work

Expected behavior
the ping works

Screenshots
image

Version Info
https://pastebin.com/9EXarwuM

Additional context
I'm not 100% sure that my implementation is correct.

But it works if I use PacketAdapter instead of MonitorAdapter.

commented

The ping does not work, but I can join the game/use the plugin without any other issue.

commented

Fixed the underlying issue, nice catch! However for your usecase I would recommend using a single PacketAdapter for the NAMED_ENTITY_SPAWN packet as it will reduce the server load :)

commented

๐Ÿ‘ Didn't see that :)

commented

I've already changed the plugin to use PacketAdapter.