ProtocolLib

Bukkit Plugins
3M Downloads

[1.19.3] Some clientbound chat packets are not picked up by packet listeners

LOOHP opened this issue ยท 1 comments

commented
  • This issue is not solved in a development build

Describe the bug
Some clientbound chat packets are not picked up by packet listeners, the didn't fire the onPacketSending method entirely. Only some of them are lost, not all. Some messages fire the listener just as normal.

To Reproduce

ProtocolLibrary.getProtocolManager().addPacketListener(new PacketAdapter(PacketAdapter.params().plugin(plugin).listenerPriority(ListenerPriority.MONITOR).types(PacketType.Play.Server.SYSTEM_CHAT, PacketType.Play.Server.CHAT)) {
    @Override
    public void onPacketSending(PacketEvent event) {
        System.out.println(event.getPacketType());
    }
});

Listen to all types of clientbound chat packets and then send chat messages. Make sure plugins are not cancelling and resending in AsyncPlayerChatEvent or other similar events, modification is fine.

Expected behavior
Packets are picked up by the listener.

Screenshots
N/A

Version Info
https://pastebin.com/KeYaS1Ez

Additional context
I suspect it has something to do with where the messages originate from/whether it is sync or async.

commented

Damn, it turns out I missed there is now a Disguised Chat packet...