ProtocolLib

3M Downloads

ServerPingRecord initializer race condition

electronicboy opened this issue ยท 1 comments

commented
  • This issue is not solved in a development build

Describe the bug

This initiaizer code is marking stuff as initialised before it actually is, thus causing a potential race condition when multiple threads try to decode this packet
https://gist.github.com/electronicboy/fc7dada07007ca6e0b1d12a29e2d7d21

To Reproduce
Steps to reproduce the behavior:
Multiple pings early during startup

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Version Info
https://paste.gg/p/anonymous/8a9b3389a2154946bd1ed3ce800e9366/files/71128597b1f64714b4f2b9020f163e54/raw

fb2075b

Additional context
reporting for a friend, can get additional info if needed, but, very unlikely

commented

This has been causing us quite a bit of issues with PremiumVanish @dmulloy2
Example: https://pastebin.com/raw/xKnnWg3q