ProtocolLib

Bukkit Plugins
3M Downloads

Is it safe to remove all the ASM related code?

pczmr8v5n454iycf opened this issue ยท 1 comments

commented

I am trying to port this plugin to a java implementation that does not support ASM, so I need to remove all the code related to ASM.
I found these two places using ASM using github search:

TileEntityAccessor

ProtocolLib/src/main/java/com/comphenix/protocol/wrappers/nbt/TileEntityAccessor.java

Line 68 in 4baa4aa

findMethodsUsingASM();

I think it is safe to remove findMethodsUsingASM() and use findMethodUsingCGLib() instead.

StructureCache

ProtocolLib/src/main/java/com/comphenix/protocol/injector/StructureCache.java

Line 127 in 4baa4aa

* @param compile - whether or not to asynchronously compile the structure modifier.

Not to compile the structure modifier seems to be safe, but I'm not sure

commented

You should be good. Performance and backwards compatibility will suffer, but it should still function. I am curious though why removing ASM is necessary/desirable?