Timings?
bobhenl opened this issue ยท 15 comments
Describe the bug
Hi, ProtocolLib has big spikes in timings.
To Reproduce
See my timings.
Expected behavior
Wouldn't be red.
Screenshots
https://imgur.com/a/Buj3PQQ and https://timings.aikar.co/?id=e84406087d56486b8e517524d225c9e4
Version Info
https://pastebin.com/yCHCNC8S
this looks more like ppl have been flying really fast, causing ton of movement packet making your enchant plugin lag out, plus the fact that your magic plugin is doing sync chunk loads doesnt help
an anticheat to limit fly speed or a packet limiter can help.
your magic plugin should use the paper api to avoid sync chunk loads, or at least do so via paperlib.
I'm using no cheat plus and using exploitfixer and illegalstack, chatcontrol and confiscate, these could block packets
We've also seen an absolutely monumental increase in tps lag due to packet processing. Here is a recent timings report, and here's a timings from two months ago. And while we've had anti-cheat, it's never eaten up resources like this, and we're only seeing this very recently, like today, and we updated from 4.5.0-SNAPSHOT to 4.5.1 last night.
After looking at a diff between 4.5.0 and 4.5.1, the biggest change appears a refactor to a synchronised deque of packets. If I had to guess what's causing the lag, it would be that.
@bergerkiller thoughts?
Hmmm @bergerkiller?
ProtocolLib::Task: com.comphenix.protocol.metrics.Metrics$1$1 (Single)count(1) total(0.03% 0.11s, 0.04% of tick)avg(110.42ms per - 0.02ms/0.00 per tick)
Yeah, still...
https://timings.aikar.co/?id=54a524f321fb4dceb7a075395332eea7
ProtocolLib::Task: com.comphenix.protocol.metrics.Metrics$1$1 (Single)count(2) total(0.15% 0.226s, 0.18% of tick)avg(113.12ms per - 0.09ms/0.00 per tick https://timings.aikar.co/?id=e68fd77a0ea6494da9025c298d0564e3
@dmulloy2