Support for 1.16
dmulloy2 opened this issue · 19 comments
General roadmap:
- Waiting on Spigot
- Minimum viable support
- Update version info and constants
- Generate new packet list
- Update PL wrappers
- Update unit tests
- Test
- Full support
- Update attributes
- Fix tile entity accessors
- Some kind of workaround for sending chat packets with default UUID
- Update dimensions
- Create new wrappers - as requested
- Update Packet Wrapper - after the dust settles
Notable packet changes
- Dimension manager wrapped in a resource key
- UUID added to chat packet
- Will throw an internal error if left out
- Workaround:
packet.getUUIDs().writeSafely(0, new UUID(0L, 0L))
Dear @dmulloy2 there is huge change at https://wiki.vg/Pre-release_protocol#Entity_Equipment
Here is a look of the NMS PacketPlayOutEntityEquipment:
https://cdn.discordapp.com/attachments/601863962904100866/726943300065689680/unknown.png
I hope You as reflection King can find a working solution to use the packet, i try it with reflection but these generic objectlist @.@ waste 4 houres of my life without solution
Getting this error spammed in console: https://pastebin.com/CfWpBD3v
Latest paper spigot 1.16.1
Latest ProtocolLib dev build (the one from few mins ago with initial support for 1.16.1)
@xph11 that's a known issue with chat packets. Looking into a way to fix it PL side but for now the workaround is for plugins that send chat packets to do this:
packet.getUUIDs().writeSafely(0, new UUID(0L, 0L))
@dmulloy2 I am a server owner, not a developer. Just thought I should report this error, though I didn't realize it has to do with another plugin and not ProtocolLib itself. Sorry :)
@Ste3et yeah unfortunately that's a real pain to do reflectively. Doable, but annoying that they couldn't just use a map. I'll look into a good solution PL side
Here is my try to reflect the Pair<F, S> from com.mojang.datafixers.util
https://gist.github.com/Ste3et/834fe69712e5e6c7ea7b243de3213538
But how i can add it to the Wrapper i didn't know 😅
I made this class: https://pastebin.com/DjP9GtmB (see at the end for the usage)
Tested on recent Paper 1.16.1
@Ste3et @Brokkonaut Added official support in f19bfc6
API is packet.getSlotStackPairLists()
Thank you @dmulloy2 for spend your time it works great
Here's something else broken with 1.16 https://paste.nomsy.net/raw/abapulogos
Hey, I tried using the getSlotStackPairLists()
-method by adding the 4.6.0-SNAPSHOT dependency to my pom (using the https://repo.dmulloy2.net/nexus/repository/public/ repo), but I can't seem to find the method.
Is the build not contained in the repo yet?
Hey, I tried using the
getSlotStackPairLists()
-method by adding the 4.6.0-SNAPSHOT dependency to my pom (using the https://repo.dmulloy2.net/nexus/repository/public/ repo), but I can't seem to find the method.
Is the build not contained in the repo yet?
@dmulloy2 for the ease of maven/gradle usage, could you add the lastest build to the nexus repository? Thanks
WrappedChatComponent#fromText doesn't support the new hex color notation (§x§9§9§9§9§9§9)
@Rincewind34 can you make a separate issue for that?
Hiya, there's an issue with your Jenkins site.
I can't get the current protocollib
https://ci.dmulloy2.net/job/ProtocolLib/lastSuccessfulBuild/