Wheel Bug with 1.15.2
StayCake opened this issue · 23 comments
Describe the bug
When clicks wheel fast, it wheels only with some blocks, and there get's too much lag.
To Reproduce
- Minecraft version: 1.15.2
- Platform: paper-334
- Ships version:
Hi there.
I will try and replicate the exact issue you have, the log you have shows that a too many actions are happening at once.
Also. What version of ships are you using?
Use "/ships info" to check the version
As in your original structure was only 1 block in size? Or out of your whole structure it only moved a single block of that?
You images are not visible.
Would you be able to send me your server ip? I can take a look myself then
Then I can only guess at what is happening here.
I believe too many actions are occurring at once. Ships already has a built-in feature to stop too many actions occurring on a single ship, however, for this feature to occur, the sign that you click needs to find the ship. The method that Ships finds the sign can take a lot of resources.
To reduce the load that the server takes, you can change the "block finder algorithm" to Ships 6 algorithm (making sure all advanced settings are set up for your server) or you can disable "auto update" on the structure which reduces the load a lot and prevents unwanted blocks from being attached to your ship, however prevents you from updating the ships structure automatically, instead you will need to manually update it by sneaking and clicking the license sign
Your crash report is reporting the issue to a line of code that no longer exists. Are you sure you are using Beta 4?
Could you go into more depth on what happens when a ship moves in water when the ship is 2 blocks deep? I am not aware of any issue with water, with the exception of having walking areas under water, which 2 blocks deep means that's unlikely the issue your referring to.
I have been unable to recreate your crash on beta 4.
Please redownload and install beta 4 to your server and then restart your server
-
The algorithm names do already use the number names instead of the number symbols.
-
there is a update on its way (beta 5) which has a config option that when disabled will stop the server from lagging
-
could you explain the bug you are having. Your lack of description makes it difficult to understand the issue your having there
-
the standard for ids in minecraft does not allow for numbers, therefore I cannot change the name to numbers.
With the config command giving you suggestions with the names of the numbers, the fact its in advanced options and the fact the default value uses the name of the number, i thought it was obvious.
You will also find that changing the name will upset current users as the settings they are used to would no longer work, instead they would need to relearn the options. -
i dont have permission to watch that video. Can you change the settings so I can watch it, or upload it to youtube as a unlisted video?
-
no sadly. The point of an id system is that it is unique, no 2 ids can do the same thing.
-
sadly thats a issue with Bukkit, whereby canceling the interact with block event while the player is in creative does not cancel. Its a issue that Bukkit will not fix.
The solution is to not move ships with creative, or to hit the signs with a sword.
Have been. In the latest release (was approved only yesterday) there is a new config option that when disabled gives much faster results.
Also been working on async block finding, while this wont speed up the block finding algorithm, it puts it on a second thread meaning that it prevents the crash of "a server tick took too long".
The ships 6 movement algorithm has been attempted to be updated so it only moves the blocks that actually change
Betas typically need more work and Ships 6 is still in that state