Shopkeepers

Shopkeepers

2M Downloads

Non-stackable items trade bug

blablubbabcDEV opened this issue ยท 2 comments

commented

Migrated from: https://dev.bukkit.org/projects/shopkeepers/issues/263

Originally posted by Cra2ytig3r (Nov 20, 2014):

What steps will reproduce the problem?
1.make sure there is more then 1 non-stackable item for trade
2.open trade window & purchase non-stackable item
3.with item still in hand. click item again to purchase.What is the expected output? What do you see instead?
Expected output:
Item clicked on be placed into inventory & payment taken from my inventory & placed into seller chest.
Instead:
Item clicked is not placed into my inventory & payment is not removed. The sellers item is removed & payment is placed in chest.What version of the product are you using?
1.26Do you have an error log of what happened?
nonePlease provide any additional information below.

commented

Originally closed by blablubbabc (Nov 21, 2014)

commented

Originally commented by blablubbabc (Nov 21, 2014):

I was able to reproduce this bug: actually minecraft doesn't seem to handle the trading in case the item on the cursor would be going to exceed the max stack size as result of the trade. Shopkeepers however still handled the item movement to and from the players chest. This should be fixed in v1.27 in the way that we now as well don't run our trading code in case the item on the cursor would exceed the max stack size as result of the trade (just like minecraft).

        Edited Nov 21, 2014