Shopkeepers

Shopkeepers

2M Downloads

Custom plugin items not working

blablubbabcDEV opened this issue ยท 7 comments

commented

Migrated from: https://dev.bukkit.org/projects/shopkeepers/issues/309

Originally posted by mrbell11 (Apr 9, 2015):

What is the issue?
The issue is that when I place a custom item in one of the shopkeeper's than reload or restart the server the custom item does not work anymore. The item is still named and their but if you buy it, it does not work like it should. If you do not restart the server it does work perfectly fine.Please provide any additional information below.

commented

Originally commented by blablubbabc (Apr 9, 2015):

I need more information on what makes this item 'custom'. Generally the item should be still the same as long as bukkit/spigot does serialize (store and load) all 'custom' data of it properly.
So if it doesn't behave as expected, then I assume that your custom item functionality is depending on something unsupported by the API, such as custom, 'raw' item data manipulation.

commented

Originally commented by blablubbabc (Apr 11, 2015):

[at]mrbell11:
What is your definition of 'custom item' / What makes your item 'custom'? How do you create your 'custom item'? What is the custom item used for?

commented

Originally commented by mrbell11 (Apr 11, 2015):

The custom item is from the Magic plugin made by Nathan Wolf (link: http://dev.bukkit.org/bukkit-plugins/magic/) The way you get it is by typing /mgive (player) wand. Than it will give it to you. The item uses custom commands and does special commands (it say's it on the link). The wand is used to do magic and attack player's (as i said before link say's most of it)

commented

Originally commented by blablubbabc (Apr 11, 2015):

[at]mrbell11:
I think to remember that items by the magic plugin have custom internal item data attached. Bukkit's item serialization (which shopkeepers uses to store and load the items) doesn't store this data.
I also think to remember that NathanWolf, the author of the magic plugin has submitted some addition to spigot, which is still pending being added/reviewed, and which would add support for that kind of custom data in the bukkit api.
I will decline this ticket for now, because I currently have no intention to replace the used bukkit item serialization with something different, less stable.

commented

Originally commented by blablubbabc (Apr 16, 2015):

[at]mrbell11:
Hey again. It seems that spigot might now handle other remaining custom inteneral item data properly. So this might no longer be an issue now.

commented

Originally commented by mrbell11 (Apr 11, 2015):

So I looked in the save file and I think It might have to do with something in their what happens is when you put a custom item in the shopkeeper than test it out it works perfectly fine. But than once you reload it the item will become a default item just with the custom name and lore still on it. So if I try to buy something using the custom item I can't buy it because the item is now a default item and not a custom item anymore.

commented

Originally closed by blablubbabc (Apr 11, 2015)