Expire time (Remove shop if not used)
blablubbabcDEV opened this issue ยท 8 comments
Migrated from: https://dev.bukkit.org/projects/shopkeepers/issues/358
Originally posted by LordDWT (Dec 22, 2015):
What is the enhancement in mind? How should it look and feel?Could you add an option to Expire a shopkeeper after X time from when it was opened?Example:
Config file:
player-shopkeeper-expire-days: 15
expire-shops-perm-options: 15,30,60
(shopkeeper.expireshops.X)Player shops by this setting would expire in 15 days.
If player had perm shopkeeper.expireshops.60 the shop would expire in 60 days.Any items in the chest should be returned to the player.Admin shops should have no expire date.I think this would help prevent abandoned shops by active players.
Allowing shop space to be freed for other players.Edit:
It would also be useful to have different shopkeepers to spawn different expire dates.Same Spawn item different Lore.SpawnEgg (15 Day)
SpawnEgg (30 Day)
SpawnEgg (60 Day)..EtcThank you for looking into it.
Originally commented by blablubbabc (Dec 23, 2015):
[at]LordDWT:
Quote:My thought on this would be to store them in a shopkeepers DB for X amount of time. If player logs in they get a notice to retrieve their items via command. If X time has passed and player does not retrieve their items they would be purged from DB.
Hm, I don't like that idea. I would prefer keeping it simpler (not having the plugin store any items) and if possible not requiring any commands.
I currently would prefer letting the items stay in the chest and instead inform the player that his shop at certain coordinates is going to expire soon. If the player doesn't remove the shop on his own and pick up his items before it expires, then it's the player's fault if his items get picked up by someone else. Similar to how the current 'expire on inactivity' already works.
A different alternative would be to only 'deactivate' the shop once it has expired, which would despawn the entity, but keep the chest locked. Then after a second expiration of a certain configured time, the chest gets unlocked again. This might be more convenient for the players, but require more changes by me for adding this feature.
However, the locked chest can not be used for another shopkeeper while it is still locked. So if you have some sort of market area, players which want to create a new shop at that location while the old shop is inactive would require a different chest there.
Originally commented by LordDWT (Dec 23, 2015):
[at]blablubbabc:
Both ideas are great and have some good advantages.
However I would prefer to warn the player before the shopkeeper expires and once the shopkeeper expires the chest is unlocked. This would free up the "stall" or shop area for another player. Also it creates a "gold sink" having to buy another shopkeeper after X time.
Edited Jan 2, 2016
Originally commented by mel_instagibson (Mar 12, 2016):
does it make sense to bump this with a comment?
if yes i just did :D
really would like to see this, would make the plugin so much easier to automate on a server!
Originally commented by blablubbabc (Dec 22, 2015):
Quote:Any items in the chest should be returned to the player.
How would this work? I can't automatically give the items from the chest to the player: The player might not be online and/or the player might not have enough inventory space.
Edited Dec 22, 2015
Originally commented by LordDWT (Dec 23, 2015):
[at]blablubbabc:
My thought on this would be to store them in a shopkeepers DB for X amount of time.
If player logs in they get a notice to retrieve their items via command.
If X time has passed and player does not retrieve their items they would be purged from DB.
Of course the alternative would be to just leave them in the chest, but then anyone has access to take the items.
I know this idea would take some work to implement. Any consideration is appreciated.
Thank you again for the awesome plugin!
Originally commented by LordDWT (Mar 13, 2016):
You should also vote this ticket too. :)
This feature would allow server owners to create a full gameplay loop. Players would be able to purchase temporary shops while avoiding shopkeeper griefing (placing shopkeepers everywhere).
At the moment the Admin or Mods have to manually remove shopkeepers. This is a pain, and stops me from creating a passive economic system for my players.
Things to consider.
- No need to return items, don't over complicate. Just delete shopkeeper and leave the chest open.
- No need to update the player through chat.
- Option for both shopkeepers to be deleted, or go back to for-hire. By default deleting is good enough as a base feature.