Shopkeepers

Shopkeepers

2M Downloads

1.9 Attributes are not properly kept

blablubbabcDEV opened this issue · 2 comments

commented

Migrated from: https://dev.bukkit.org/projects/shopkeepers/issues/367

Originally posted by gunsomc (Mar 12, 2016):

What steps will reproduce the problem?

  1. Create an item with attributes such as generic.armor/Slot:chest and place in villager for a trade
  2. Restart server or reload settings
  3. Trade with villager, and now item has all the attributes for all slots, not just slot originally specified when item was createdWhat is the expected output? What do you see instead?expected output is exact item place in Villager, yet attributes are changed.  Probably due to changes in how 1.8 and 1.9 use attributes.What version of the product are you using?v1.70Do you have an error log of what happened?no errorsPlease provide any additional information below.I'm assuming this is caused by the changes in how attributes are handled in minecraft 1.9, since 1.9 added the "Slot" variable to attributes.  Using Shopkeepers probably reverts the item to 1.8 type attributes, which causes the item to show the attributes listed for every possible slot.
commented

Originally commented by blablubbabc (Apr 8, 2016):

Check out v1.71. I completely removed the custom attribute saving there, since bukkit seems to properly save the attributes to the config itself by now, including the new Slot attribute in MC 1.9.

Custom attribute loading is left in for now, in case someone updates from versions in which bukkit didn't save those attributes yet.

commented

Originally closed by blablubbabc (Apr 8, 2016)