Shopkeepers turns into normal villagers
blablubbabcDEV opened this issue ยท 4 comments
Migrated from: https://dev.bukkit.org/projects/shopkeepers/issues/372
Originally posted by Joakim1398 (Mar 22, 2016):
What steps will reproduce the problem?
- I reload the plugin
- Wait
- They go into normal villagers and walk away. Worked in 1.8, but after updating to 1.9 (Both spigot and shopkeepers) it started doing that.What is the expected output? What do you see instead?
Normal shopkeepers and not villagers that walk, or have default trades..What version of the product are you using?
LatestDo you have an error log of what happened?
There's no error that I can find.Please provide any additional information below.
Originally commented by blablubbabc (Mar 22, 2016):
Do the entities duplicate (one staying the active shopkeeper, and a clone starting to walk around), or do the shop entities themself turn into normal entities (walk around)?
In the first case this might be a duplicate of this issue:
http://dev.bukkit.org/bukkit-plugins/shopkeepers/tickets/268-shops-duplicating/
I can reload the plugin without problems on 1.9 though. So there might be something else that changed for you.
Did your server maybe crash, after or during the reload? Did the entities copy and started moving around after you restarted the server after the crash?
In the second case:
Did your save.yml file (inside the shopkeepers plugins folder) get wiped (is it empty/ doesn't contain all of your shopkeepers anymore)? In this case this might be a different issue than the one linked above.
Please check your server log for errors, especially in the second case.
Edited Mar 22, 2016
Originally commented by Joakim1398 (Mar 23, 2016):
[at]blablubbabc:
No, they don't duplicate, they just transform to normal villagers at the shop location and keep their shop name, then they start to walk all over the place. I found a way to reproduce the problem, by being offline and then jump back online a few minutes later, then it happens. No errors or anything like that in the logs.
The save.yml contains data.
EDIT:
I think ClearLagg causes it! When it unloads chunks, the shops go crazy. Note that this worked just fine in 1.8
The reason the shops turns into normal villagers while being offline is because I had it so that ClearLagg unloaded chunks when nobody is online.
Edited Mar 23, 2016
Originally commented by blablubbabc (Mar 23, 2016):
[at]Joakim1398:
Quote:I think ClearLagg causes it! When it unloads chunks, the shops go crazy. Note that this worked just fine in 1.8 The reason the shops turns into normal villagers while being offline is because I had it so that ClearLagg unloaded chunks when nobody is online.
Oh yeah that makes sense. I created a ticket for it there: http://dev.bukkit.org/bukkit-plugins/clearlagg/tickets/124-unloading-chunks-without-calling-chunk-unload-event/
However, there is some protection inside shopkeepers which should usually allow shopkeepers to detect when an other plugin is unloading a chunk without informing other plugins. Though, there also seems to be a spigot bug as far as I can tell (https://hub.spigotmc.org/jira/browse/SPIGOT-2033), which seems to prevent this currently.