Shopkeepers

Shopkeepers

2M Downloads

Shift+Rightclick doesn't work in trading

blablubbabcDEV opened this issue ยท 7 comments

commented

Migrated from: https://dev.bukkit.org/projects/shopkeepers/issues/436

Originally posted by MrJonton01 (Sep 24, 2016):

When I try to take a traded item/output item out using rightclick or SHIFT+Rightclick it doesn't work. Here are the debug information from the console: http://prntscr.com/clr3f8
I'm using the newest version of Shopkeepers
I hope you will fix/change it soon.~ MrJonton01

commented

Should be fixed in v1.87. Please let me know of any issues.

commented

This might be solved with bbd4373

commented

Originally commented by MrJonton01 (Sep 24, 2016):

[at]blablubbabc:
Oh okay... but I have an idea: make a config option in which you can enable this if that works...

commented

Originally commented by blablubbabc (Sep 24, 2016):

I will first have to look whether I can improve the logic for determining which and how many items were traded for certain types of clicks.
Until then I will leave this ticket open as reminder. If you want to try it out on your own risk, feel free to make the required modifications for that yourself. The source code is on github. You would have to disable the following lines of code: https://github.com/nisovin/Shopkeepers/blob/master/src/main/java/com/nisovin/shopkeepers/ui/defaults/TradingHandler.java#L85

commented

Originally commented by blablubbabc (Sep 24, 2016):

Shopkeepers is preventing those types of clicks for player shops because it can't determine how many items were actually traded in certain situations, and if I remember correctly there was some kind of duplication bug in the past due to those kind of clicks.

commented

Originally commented by HackerOTVW (May 18, 2017):

Please edit it, I can not create a shopkeeper when it is not working :(
Edited May 18, 2017

commented

Originally commented by blablubbabc (May 18, 2017):

? Shopkeeper creation should not be affected by this. If you have an issues with that, then please create a separate ticket and describe your issue there.
Edited May 18, 2017