Shopkeepers

Shopkeepers

Bukkit Plugins
2M Downloads

Utils.isSimilar no longer ignores displayname/lore even if empty (since may 2016)

blablubbabcDEV opened this issue · 2 comments

commented

Migrated from: https://dev.bukkit.org/projects/shopkeepers/issues/518

Originally posted by blablubbabc (Mar 13, 2017):

Since a commit in may 2016 (nisovin@a5ffdf3):
 
Utils.isSimilar was changed to no longer ignore empty display names and lore. It now makes sure that the item has no  display name/lore in this case.
 
Really intended? Why was that changed again? Can it be reversed without breaking something else?

commented

Originally closed by blablubbabc (May 27, 2017)

commented

Originally commented by blablubbabc (May 27, 2017):

Reverted that change for version 1.83. Empty display name / lore will skip the comparison check again.
Edited May 27, 2017